Bug 216074 - databases/soci: fails to build with clang 4.0
Summary: databases/soci: fails to build with clang 4.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Julien Laffaye
URL: https://reviews.freebsd.org/D13769
Keywords:
Depends on:
Blocks: 216008
  Show dependency treegraph
 
Reported: 2017-01-14 15:57 UTC by Jan Beich
Modified: 2018-01-05 11:08 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (jlaffaye)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2017-01-14 15:57:57 UTC
backends/mysql/session.cpp:202:22: error: ordered comparison between pointer and zero ('int *' and 'int')
            if (port < 0)
                ~~~~ ^ ~

build log: http://sprunge.us/dQUT
regressed by: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3
Comment 1 Adriaan de Groot freebsd_committer 2018-01-04 20:46:02 UTC
Patch (from upstream) is in the review.
Comment 2 commit-hook freebsd_committer 2018-01-05 11:06:38 UTC
A commit references this bug:

Author: adridg
Date: Fri Jan  5 11:06:16 UTC 2018
New revision: 458126
URL: https://svnweb.freebsd.org/changeset/ports/458126

Log:
  Fix build of databases/soci w/ clang 4.0 and later and on arm6, arm7.
  Adds upstream patch to fix

  backends/mysql/session.cpp:202:22: error: ordered comparison between pointer and zero ('int *' and 'int')
              if (port < 0)

  PR:		222651 216074
  Reported by:	jbeich, Neel Chauhan
  Reviewed by:	jlaffaye
  Approved by:	tcberner (mentor)
  Obtained from:	upstream
  Differential Revision:	https://reviews.freebsd.org/D13769

Changes:
  head/databases/soci/Makefile
  head/databases/soci/files/patch-backends_mysql_session.cpp