Bug 216160 - multimedia/assimp: fails to build with clang 4.0 (6 ports skipped)
Summary: multimedia/assimp: fails to build with clang 4.0 (6 ports skipped)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords: needs-patch
Depends on:
Blocks: 216008
  Show dependency treegraph
 
Reported: 2017-01-17 08:08 UTC by Jan Beich
Modified: 2017-01-19 05:10 UTC (History)
0 users

See Also:
yuri: maintainer-feedback+


Attachments
typo fix (1.95 KB, patch)
2017-01-17 11:05 UTC, Jan Beich
yuri: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2017-01-17 08:08:51 UTC
code/D3MFImporter.cpp:230:29: error: invalid operands to binary expression ('float (*)(const char *, const char *)' and 'nullptr_t')
        vertex.z = ai_strtof>(xmlReader->getAttributeValue(D3MF::XmlTag::z.c_str()), nullptr);
                   ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

build log: http://sprunge.us/MRJJ
likely due to: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3
Comment 1 Yuri Victorovich freebsd_committer 2017-01-17 08:20:39 UTC
Upstream: https://github.com/assimp/assimp/issues/1141
Comment 2 Jan Beich freebsd_committer 2017-01-17 09:56:04 UTC
"> NULL" should be spelled as "!= NULL" which should hint you're dealing with a typo here. Anyway, to reproduce on earlier FreeBSD releases try

  $ pkg install llvm-devel
  $ make clean all CC=clang-devel CXX=clang++-devel CPP=clang-cpp-devel
Comment 3 Yuri Victorovich freebsd_committer 2017-01-17 10:04:47 UTC
Can you just add a patch if possible?
Comment 4 Jan Beich freebsd_committer 2017-01-17 11:05:11 UTC
Created attachment 178990 [details]
typo fix

This fixes a regression from https://github.com/assimp/assimp/commit/9b6de15b74f4d44220f0514766d6344f6238cf2f
Comment 5 commit-hook freebsd_committer 2017-01-17 17:23:22 UTC
A commit references this bug:

Author: jbeich
Date: Tue Jan 17 17:22:21 UTC 2017
New revision: 431762
URL: https://svnweb.freebsd.org/changeset/ports/431762

Log:
  multimedia/assimp: unbreak build with clang 4.0

  code/D3MFImporter.cpp:230:29: error: invalid operands to binary expression ('float (*)(const char *, const char *)' and 'nullptr_t')
          vertex.z = ai_strtof>(xmlReader->getAttributeValue(D3MF::XmlTag::z.c_str()), nullptr);
                     ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  PR:		216160
  Approved by:	Yuri Victorovich <yuri@rawbw.com> (maintainer)
  MFH:		2017Q1 (changes behavior)

Changes:
  head/multimedia/assimp/Makefile
  head/multimedia/assimp/files/
  head/multimedia/assimp/files/patch-code_D3MFImporter.cpp
Comment 6 commit-hook freebsd_committer 2017-01-19 05:10:22 UTC
A commit references this bug:

Author: jbeich
Date: Thu Jan 19 05:09:49 UTC 2017
New revision: 431841
URL: https://svnweb.freebsd.org/changeset/ports/431841

Log:
  MFH: r431762

  multimedia/assimp: unbreak build with clang 4.0

  code/D3MFImporter.cpp:230:29: error: invalid operands to binary expression ('float (*)(const char *, const char *)' and 'nullptr_t')
          vertex.z = ai_strtof>(xmlReader->getAttributeValue(D3MF::XmlTag::z.c_str()), nullptr);
                     ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  PR:		216160
  Approved by:	Yuri Victorovich <yuri@rawbw.com> (maintainer)
  Approved by:	ports-secteam (feld)

Changes:
_U  branches/2017Q1/
  branches/2017Q1/multimedia/assimp/Makefile
  branches/2017Q1/multimedia/assimp/files/