Bug 216176 - x11-wm/fluxbox: fails to build with clang 4.0 (5 ports skipped)
Summary: x11-wm/fluxbox: fails to build with clang 4.0 (5 ports skipped)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias C. Berner
URL:
Keywords: needs-patch
Depends on:
Blocks: 216008
  Show dependency treegraph
 
Reported: 2017-01-17 11:33 UTC by Jan Beich
Modified: 2017-01-31 00:04 UTC (History)
1 user (show)

See Also:


Attachments
upstream commit (1.38 KB, patch)
2017-01-21 20:44 UTC, Tobias C. Berner
no flags Details | Diff
regenerated patch (1.28 KB, patch)
2017-01-21 21:19 UTC, Tobias C. Berner
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2017-01-17 11:33:05 UTC
util/fluxbox-remote.cc:76:32: error: ordered comparison between pointer and zero ('unsigned char *' and 'int')
            && text_prop.value > 0
               ~~~~~~~~~~~~~~~ ^ ~

build log: http://sprunge.us/YOgf
regressed by: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3
Comment 2 Jan Beich freebsd_committer 2017-01-21 21:15:48 UTC
Comment on attachment 179192 [details]
upstream commit

Upstream commit message looks cryptic. Since this affects just one file, reformat it via "make makepatch" then paste the link to the bug and commit at the top.

The fix itself looks innocuous enough to land under "portmgr blanket" + "ports-secteam blanket" (to 2017Q1) without bumping PORTREVISION. I confirm it's enough to unbreak build on clang400-import@312309 i386: http://sprunge.us/CfKH
Comment 3 Tobias C. Berner freebsd_committer 2017-01-21 21:19:24 UTC
Created attachment 179194 [details]
regenerated patch
Comment 4 Jan Beich freebsd_committer 2017-01-21 21:23:39 UTC
Comment on attachment 179194 [details]
regenerated patch

Looks OK now.
Comment 5 commit-hook freebsd_committer 2017-01-21 22:14:40 UTC
A commit references this bug:

Author: tcberner
Date: Sat Jan 21 22:14:23 UTC 2017
New revision: 432090
URL: https://svnweb.freebsd.org/changeset/ports/432090

Log:
  Fix graphics/py-poppler-qt4: fails to build with clang 4.0

  Import upstream commit
  http://git.fluxbox.org/fluxbox.git/commit/util/fluxbox-remote.cc?id=22866c4d30f5b289c429c5ca88d800200db4fc4f
  for issue
  https://sourceforge.net/p/fluxbox/bugs/1138/

  PR:		216176
  Approved by:	portmgr blanket, rakuco (mentor)
  MFH:		2017Q1

Changes:
  head/x11-wm/fluxbox/files/patch-util_fluxbox-remote.cc
Comment 6 commit-hook freebsd_committer 2017-01-22 12:57:40 UTC
A commit references this bug:

Author: tcberner
Date: Sun Jan 22 12:57:04 UTC 2017
New revision: 432129
URL: https://svnweb.freebsd.org/changeset/ports/432129

Log:
  MFH: r432090

  Fix x11-wm/fluxbox: fails to build with clang 4.0

  Import upstream commit
  http://git.fluxbox.org/fluxbox.git/commit/util/fluxbox-remote.cc?id=22866c4d30f5b289c429c5ca88d800200db4fc4f
  for issue
  https://sourceforge.net/p/fluxbox/bugs/1138/

  PR:		216176
  Approved by:	portmgr blanket, rakuco (mentor)

  Approved by:	ports-secteam (junovitch), rakuco (mentor)

Changes:
_U  branches/2017Q1/
  branches/2017Q1/x11-wm/fluxbox/files/patch-util_fluxbox-remote.cc