Bug 216199 - comms/fldigi: fails to build with clang 4.0
Summary: comms/fldigi: fails to build with clang 4.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: hamradio
URL:
Keywords: needs-patch
Depends on:
Blocks: 216008
  Show dependency treegraph
 
Reported: 2017-01-17 23:04 UTC by Jan Beich
Modified: 2017-03-27 12:29 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (hamradio)


Attachments
possible-patch (12.82 KB, patch)
2017-03-07 10:23 UTC, Walter Schwarzenfeld
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2017-01-17 23:04:26 UTC
logbook/adif_io.cxx:314:15: error: ordered comparison between pointer and zero ('char *' and 'int')
                        if ((ptr2) > 0 && (unsigned)(ptr2 - ptr) <= p)
                            ~~~~~~ ^ ~

build log: http://sprunge.us/VTEb
regressed by: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3
Comment 1 Walter Schwarzenfeld freebsd_triage 2017-03-07 10:23:45 UTC
Created attachment 180595 [details]
possible-patch

I am uncertain about the lookupcall.c-patch, but 
      (aka 'char') changes value from 184 to -72 [-Wconstant-conversion]
        if ((p = htmlpage.find(HAMCALL_FIRST)) != string::npos) {
                          ~~~~ ^~~~~~~~~~~~~
logbook/lookupcall.cxx:715:23: note: expanded from macro 'HAMCALL_FIRST'
#define HAMCALL_FIRST 184
--
      (aka 'char') changes value from 191 to -65 [-Wconstant-conversion]
        if ((p = htmlpage.find(HAMCALL_CITY)) != string::npos) {
                          ~~~~ ^~~~~~~~~~~~
logbook/lookupcall.cxx:716:22: note: expanded from macro 'HAMCALL_CITY'
#define HAMCALL_CITY 191
--
      (aka 'char') changes value from 192 to -64 [-Wconstant-conversion]
        if ((p = htmlpage.find(HAMCALL_STATE)) != string::npos) {
                          ~~~~ ^~~~~~~~~~~~~
logbook/lookupcall.cxx:717:23: note: expanded from macro 'HAMCALL_STATE'
#define HAMCALL_STATE 192
--
      (aka 'char') changes value from 202 to -54 [-Wconstant-conversion]
        if ((p = htmlpage.find(HAMCALL_GRID)) != string::npos) {
                          ~~~~ ^~~~~~~~~~~~
logbook/lookupcall.cxx:718:22: note: expanded from macro 'HAMCALL_GRID'


seems not to be right.
Comment 2 Walter Schwarzenfeld freebsd_triage 2017-03-27 11:11:00 UTC
Could closed. The maintainer has updated the port:
https://svnweb.freebsd.org/ports?view=revision&revision=436980

Don't know why it is not noticed here.
Comment 3 Walter Schwarzenfeld freebsd_triage 2017-03-27 11:11:55 UTC
Forgot:
And solved the error.
Comment 4 Diane Bruce freebsd_committer 2017-03-27 12:28:45 UTC
Since upstream is currently in alpha testing it made more sense to do an interim quick patch and not introduce tons of extra patches into our own port.