Bug 216203 - games/flightgear: fails to build with clang 4.0
Summary: games/flightgear: fails to build with clang 4.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ganael LAPLANCHE
URL:
Keywords: needs-patch
Depends on:
Blocks: 216008
  Show dependency tree / graph
 
Reported: 2017-01-17 23:27 UTC by Jan Beich
Modified: 2017-01-31 00:04 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (martymac)

Attachments
Patch (303 bytes, patch)
2017-01-20 23:01 UTC, Ganael LAPLANCHE 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2017-01-17 23:27:41 UTC 
src/FDM/JSBSim/FGFDMExec.cpp:214:14: error: ordered comparison between pointer and zero ('unsigned int *' and 'int')
  if (FDMctr > 0) (*FDMctr)--;
      ~~~~~~ ^ ~

build log: http://sprunge.us/YEKE
regressed by: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3
Comment 1 Ganael LAPLANCHE freebsd_committer freebsd_triage 2017-01-20 23:01:24 UTC 
Created attachment 179166 [details]
Patch

Hi Jan,

Thanks for taking care of that.

Can you confirm that this patch (put into the files/ directory of the port) fixes the issue ?

Thank you very much,

Best regards,

Ganael.
Comment 2 Jan Beich freebsd_committer freebsd_triage 2017-01-20 23:30:15 UTC 
Comment on attachment 179166 [details]
Patch

src/FDM/JSBSim/input_output/FGInputSocket.cpp:195:25: error: ordered comparison between pointer and zero ('JSBSim::FGPropertyNode *' and 'int')
        } else if (node > 0) {
                   ~~~~ ^ ~

build log: http://sprunge.us/hLCh
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-01-21 21:23:53 UTC 
A commit references this bug:

Author: martymac
Date: Sat Jan 21 21:23:46 UTC 2017
New revision: 432081
URL: https://svnweb.freebsd.org/changeset/ports/432081

Log:
  Fix build with Clang 4.0.0

  PR:		216203
  Submitted by:	jbeich

Changes:
  head/games/flightgear/Makefile
  head/games/flightgear/files/patch-CLANG_4.txt
Comment 4 Ganael LAPLANCHE freebsd_committer freebsd_triage 2017-01-21 21:25:38 UTC 
I could reproduce build problems with clang-devel-5.0.d20170114_1.

I've just committed a fix for those build errors.

Thanks Jan !
Comment 5 Jan Beich freebsd_committer freebsd_triage 2017-01-21 21:33:14 UTC 
I confirm, it builds fine on /projects/clang400-import@312309 i386: http://sprunge.us/AHgR
Comment 6 Ganael LAPLANCHE freebsd_committer freebsd_triage 2017-01-21 21:44:50 UTC 
Perfect, thanks again :)