Bug 216218 - devel/ruby-qtruby: fails to build with clang 4.0
Summary: devel/ruby-qtruby: fails to build with clang 4.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: kde
URL:
Keywords: needs-patch
Depends on:
Blocks: 216008
  Show dependency treegraph
 
Reported: 2017-01-18 08:40 UTC by Jan Beich
Modified: 2017-01-31 00:04 UTC (History)
1 user (show)

See Also:
tcberner: maintainer-feedback+


Attachments
fix bogus pointer comparison (945 bytes, patch)
2017-01-18 20:24 UTC, Tobias C. Berner
tcberner: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2017-01-18 08:40:11 UTC
src/qtruby.cpp:2097:17: error: ordered comparison between pointer and zero ('void *' and 'int')
    return (ptr > 0 ? Qtrue : Qfalse);
            ~~~ ^ ~

build log: http://sprunge.us/CCYd
regressed by: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3
Comment 1 Tobias C. Berner freebsd_committer 2017-01-18 20:24:42 UTC
Created attachment 179047 [details]
fix bogus pointer comparison
Comment 2 Jan Beich freebsd_committer 2017-01-18 21:12:53 UTC
Comment on attachment 179047 [details]
fix bogus pointer comparison

Builds fine with the patch: http://sprunge.us/MDHM
Comment 3 commit-hook freebsd_committer 2017-01-20 12:45:54 UTC
A commit references this bug:

Author: tcberner
Date: Fri Jan 20 12:45:04 UTC 2017
New revision: 431952
URL: https://svnweb.freebsd.org/changeset/ports/431952

Log:
  Fix ruby-qtruby with newer clang

  Clang 4.0 trips on the bogus  pointer comparison.
  As the produced code may change, bump PORTREVISION.

  PR:		216218
  Reported by:	jbeich
  Approved by:	rakuco (mentor)

Changes:
  head/devel/ruby-qtruby/Makefile
  head/devel/ruby-qtruby/files/patch-src_qtruby.cpp
Comment 4 Jan Beich freebsd_committer 2017-01-20 19:55:56 UTC
(In reply to commit-hook from comment #3)
Can you MFH it into 2017Q1? This can probably use "Approved by: ports-secteam blanket" since the existing behavior doesn't change.

https://wiki.freebsd.org/ports-secteam#Blanket_Approval
Comment 5 commit-hook freebsd_committer 2017-01-21 12:17:00 UTC
A commit references this bug:

Author: tcberner
Date: Sat Jan 21 12:16:01 UTC 2017
New revision: 432025
URL: https://svnweb.freebsd.org/changeset/ports/432025

Log:
  MFH: r431952

  Fix ruby-qtruby with newer clang

  Clang 4.0 trips on the bogus  pointer comparison.
  As the produced code may change, bump PORTREVISION.

  PR:		216218
  Reported by:	jbeich
  Approved by:	rakuco (mentor)

  PR:             216218
  Approved by:	ports-secteam (junovitch), rakuco (mentor)

Changes:
_U  branches/2017Q1/
  branches/2017Q1/devel/ruby-qtruby/Makefile
  branches/2017Q1/devel/ruby-qtruby/files/patch-src_qtruby.cpp
Comment 6 commit-hook freebsd_committer 2017-01-21 12:17:01 UTC
A commit references this bug:

Author: tcberner
Date: Sat Jan 21 12:16:01 UTC 2017
New revision: 432025
URL: https://svnweb.freebsd.org/changeset/ports/432025

Log:
  MFH: r431952

  Fix ruby-qtruby with newer clang

  Clang 4.0 trips on the bogus  pointer comparison.
  As the produced code may change, bump PORTREVISION.

  PR:		216218
  Reported by:	jbeich
  Approved by:	rakuco (mentor)

  PR:             216218
  Approved by:	ports-secteam (junovitch), rakuco (mentor)

Changes:
_U  branches/2017Q1/
  branches/2017Q1/devel/ruby-qtruby/Makefile
  branches/2017Q1/devel/ruby-qtruby/files/patch-src_qtruby.cpp