Bug 216227 - devel/godot: fails to build with clang 4.0
Summary: devel/godot: fails to build with clang 4.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
Keywords: needs-patch
Depends on:
Blocks: 216008
  Show dependency treegraph
Reported: 2017-01-18 11:48 UTC by Jan Beich
Modified: 2017-02-01 04:00 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (FreeBSD)

devel/godot maintainer update (20.82 KB, patch)
2017-01-27 21:53 UTC, Shane
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2017-01-18 11:48:52 UTC
scene/gui/tree.cpp:1295:27: error: ordered comparison between pointer and zero
      ('TreeItem *' and 'int')
                                if (c->get_children() > 0)
                                    ~~~~~~~~~~~~~~~~~ ^ ~

build log: http://sprunge.us/AVWL (interleaved due to ALLOW_MAKE_JOBS)
regressed by: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3
Comment 1 Shane 2017-01-27 21:53:34 UTC
Created attachment 179361 [details]
devel/godot maintainer update

Update devel/godot to 2.1.2, the failing code has been updated in this release.

Use of external projects that have been bundled with this project are starting to be changed. freetype and png should either both be external or both internal as mixing leads to issues. After code shuffling the internal copy of musepack and speex fail to work and adding them as external dependencies is just easier than fixing it, I think these are also planned to be used as external libs in future releases. This all leads to more changes than expected in a minor point release.
Comment 2 commit-hook freebsd_committer 2017-01-28 18:34:00 UTC
A commit references this bug:

Author: jbeich
Date: Sat Jan 28 18:33:12 UTC 2017
New revision: 432641
URL: https://svnweb.freebsd.org/changeset/ports/432641

  devel/godot: update to 2.1.2

  Changes:	https://godotengine.org/article/maintenance-release-godot-2-1-1
  Changes:	https://godotengine.org/article/maintenance-release-godot-2-1-2
  PR:		216227
  Submitted by:	Shane <FreeBSD@ShaneWare.Biz> (maintainer)

Comment 3 Jan Beich freebsd_committer 2017-01-28 18:34:31 UTC
Thanks. Landed.
Comment 5 Shane 2017-02-01 04:00:14 UTC
For anyone using this as reference - the relevant godot commit is https://github.com/godotengine/godot/commit/31f929caa2

the code change was 

- if (pointer > 0)
+ if (pointer != NULL)

In sys/_null.h NULL gets defined as nullptr which is defined in c++/v1/__nullptr