Bug 216317 - net-mgmt/flow-tools: patch to compile with clang
Summary: net-mgmt/flow-tools: patch to compile with clang
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Muhammad Moinur Rahman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-20 16:37 UTC by Victor Sudakov
Modified: 2017-03-05 19:44 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (bofh)


Attachments
Patch to remove inline functions (25.19 KB, patch)
2017-01-20 16:37 UTC, Victor Sudakov
no flags Details | Diff
use gnu89 mode (762 bytes, patch)
2017-01-22 08:06 UTC, Eugene Grosbein
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Sudakov 2017-01-20 16:37:34 UTC
Created attachment 179142 [details]
Patch to remove inline functions

I suggest a patch which will permit to remove USE_GCC= from the port.
USE_GCC is ugly because it installs many runtime dependencies.
Comment 1 Eugene Grosbein 2017-01-22 08:06:49 UTC
Created attachment 179207 [details]
use gnu89 mode
Comment 2 Eugene Grosbein 2017-01-22 08:07:16 UTC
The problem can be solved simplier with single-line patch switching Clang from its default c99 mode to GCC's default gnu89 mode. The patch is attached.
Comment 3 Victor Sudakov 2017-01-22 08:38:11 UTC
(In reply to Eugene Grosbein from comment #2)
Thanks, your solution is much more correct.
Comment 4 Victor Sudakov 2017-03-05 04:29:29 UTC
Dear Muhammad,

The solution is a one line patch. Why not commit it and move on?
Comment 5 Muhammad Moinur Rahman freebsd_committer 2017-03-05 19:43:19 UTC
(In reply to vas from comment #4)
This has been fixed at revision 433278.
https://svnweb.freebsd.org/ports/head/net-mgmt/flow-tools/Makefile?r1=426566&r2=433278&pathrev=433346