Bug 216412 - mail/isoqlog: Fix MASTER_SITES
Summary: mail/isoqlog: Fix MASTER_SITES
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Sunpoet Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-23 18:19 UTC by Danilo G. Baio
Modified: 2017-01-23 18:56 UTC (History)
0 users

See Also:


Attachments
isoqlog-2.2.1_1.patch (9.94 KB, patch)
2017-01-23 18:19 UTC, Danilo G. Baio
dbaio: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Danilo G. Baio freebsd_committer 2017-01-23 18:19:21 UTC
Created attachment 179261 [details]
isoqlog-2.2.1_1.patch

- Remove inactive addresses on MASTER_SITES
- Improve port (Set LICENSE_FILE; Remove PORTDOCS from pkg-plist;
  Re-generate patches;)

IMHO it's not necessary to bump PORTREVISION.

[Q/A]

portlint: OK (looks fine)
testport:
   poudriere: i386|amd64 - 10.3 p16     (OK)
   poudriere: i386|amd64 - 11   p7      (OK) 
   poudriere: i386|amd64 - 12   r312317 (OK)
Comment 1 Sunpoet Po-Chuan Hsieh freebsd_committer 2017-01-23 18:35:18 UTC
FYI, I'd use 'svn mv' to preserve the history of patch files. The status is now as follows:

D       files/patch-Data.c
        > moved to files/patch-isoqlog_Data.c
D       files/patch-Data.h
        > moved to files/patch-isoqlog_Data.h
A  +    files/patch-isoqlog_Data.c
        > moved from files/patch-Data.c
A  +    files/patch-isoqlog_Data.h
        > moved from files/patch-Data.h
Comment 2 Danilo G. Baio freebsd_committer 2017-01-23 18:50:40 UTC
(In reply to Po-Chuan Hsieh from comment #1)

Understood. Thank you for the feedback. If you want a new patch, let me know.
Comment 3 commit-hook freebsd_committer 2017-01-23 18:53:41 UTC
A commit references this bug:

Author: sunpoet
Date: Mon Jan 23 18:52:22 UTC 2017
New revision: 432285
URL: https://svnweb.freebsd.org/changeset/ports/432285

Log:
  Clean up MASTER_SITES

  - Add LICENSE_FILE
  - Use PORTDOCS
  - Regenerate patch files with makepatch:
  - While I'm here:
    - Fix indent
    - Remove superfluous space in PLIST

  PR:		216412
  Submitted by:	Danilo G. Baio (dbaio) <dbaio@bsd.com.br> (maintainer)

Changes:
  head/mail/isoqlog/Makefile
  head/mail/isoqlog/distinfo
  head/mail/isoqlog/files/patch-Data.c
  head/mail/isoqlog/files/patch-Data.h
  head/mail/isoqlog/files/patch-isoqlog_Data.c
  head/mail/isoqlog/files/patch-isoqlog_Data.h
  head/mail/isoqlog/pkg-plist
Comment 4 Sunpoet Po-Chuan Hsieh freebsd_committer 2017-01-23 18:56:33 UTC
Committed. Thanks!