Bug 216463 - [PATCH] net/wireshark add androiddump option, remove adns, fix gtk/qt
Summary: [PATCH] net/wireshark add androiddump option, remove adns, fix gtk/qt
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Joe Marcus Clarke
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-01-25 15:56 UTC by Marcin Gryszkalis
Modified: 2017-01-26 17:08 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (marcus)


Attachments
updated Makefile (2.62 KB, patch)
2017-01-25 15:56 UTC, Marcin Gryszkalis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marcin Gryszkalis 2017-01-25 15:56:57 UTC
Created attachment 179310 [details]
updated Makefile

1. androiddump

There's serious upstream problem with long (75s) startup delay when androiddump is available (it tries to connect to not-existing adb).

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13104

2. adns
gnu ADNS support was removed from wireshark
https://www.wireshark.org/lists/wireshark-dev/201603/msg00092.html

switched to simple checkbox for c-ares

3. typo in PLIST_SUB
%x -- fixed

4. gtk/qt options
changed as described in ./configure

  --with-qt=[yes/no/4/5]  use Qt [default=yes, if available]
  --with-gtk=[yes/no/2/3] use GTK+ [default=yes, if available]
Comment 1 Joe Marcus Clarke freebsd_committer 2017-01-26 17:08:06 UTC
Committed, thanks!
Comment 2 commit-hook freebsd_committer 2017-01-26 17:08:42 UTC
A commit references this bug:

Author: marcus
Date: Thu Jan 26 17:07:49 UTC 2017
New revision: 432519
URL: https://svnweb.freebsd.org/changeset/ports/432519

Log:
  Update to 2.2.4.  See
  https://www.wireshark.org/docs/relnotes/wireshark-2.2.4.html for a list of what's new.

  * Remove support for libadns [1]
  * Make androiddump optional [1]
  * Fix a Makefile typo [1]

  PR:		216463 [1]
  Submitted by:	Marcin Gryszkalis <mg@fork.pl>

Changes:
  head/net/wireshark/Makefile
  head/net/wireshark/distinfo
  head/net/wireshark/pkg-plist