Bug 216499 - [new port] audio/eq10q: Set of mono and stereo parametric equalizers
Summary: [new port] audio/eq10q: Set of mono and stereo parametric equalizers
Status: Closed DUPLICATE of bug 222113
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-26 17:33 UTC by Goran Mekić
Modified: 2017-09-13 16:42 UTC (History)
1 user (show)

See Also:
meka: maintainer-feedback+

Attachments
eq10q.shar (99.04 KB, text/plain)
2017-01-26 17:33 UTC, Goran Mekić 		no flags Details
eq10q.shar (8.51 KB, text/plain)
2017-01-26 21:46 UTC, Goran Mekić 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Goran Mekić 2017-01-26 17:33:15 UTC 
Created attachment 179334 [details]
eq10q.shar
Comment 1 Goran Mekić 2017-01-26 21:46:59 UTC 
Created attachment 179340 [details]
eq10q.shar

My editor stripped white spaces by default, making patches big, hence the new shar.
Comment 2 Goran Mekić 2017-05-28 22:20:33 UTC 
Anybody home? :)
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2017-09-13 08:41:34 UTC 
Hi Goran,

I accidentally submitted another version of the same package (bug#222113) among many other LV2 plugins, because I didn't notice your port submission.

Your port has several issues:
* It lacks -lv2 suffix
* It uses patches under files/ when it's preferred to patch from Makefile when possible (one-liners like these)
* It doesn't take advantage of USES for gtkmm, etc which is required
* It has a redundant RUN_DEPENDS on Jack, when LV2 plugins don't normally depend on Jack
* It fails to build in 10.X because it keeps -finline-functions-called-once which isn't supported there
* It doesn't remove -O3 from Makefiles, so it's impossible to debug if needed

I am not insisting, but do you mind dropping your submission in favor of bug#222113 because it is already free of these problems?
Alternatively, you can fix them, or just copy bug#222113 over, and I will then drop bug#222113?
Either way, but only one should be left to make the work of the committer easier.

Thanks!
Yuri
Comment 4 Goran Mekić 2017-09-13 15:00:31 UTC 
I'm so glad audio app number grows! I'll drop this PR as yours looks much nicer.

*** This bug has been marked as a duplicate of bug 222113 ***
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2017-09-13 16:42:32 UTC 
Thank you!

Yuri