Bug 216561 - graphics/darktable: update to 2.2.2, assorted fixes
Summary: graphics/darktable: update to 2.2.2, assorted fixes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jean-Sébastien Pédron
URL:
Keywords: patch
Depends on:
Blocks: 199098
  Show dependency treegraph
 
Reported: 2017-01-29 01:38 UTC by Matthias Andree
Modified: 2017-01-30 21:15 UTC (History)
2 users (show)

See Also:
dumbbell: maintainer-feedback+
dumbbell: maintainer-feedback+


Attachments
patch against ports/graphics/darktable for update to 2.2.2 with assorted other fixes (1.51 KB, patch)
2017-01-29 12:43 UTC, Matthias Andree
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Andree freebsd_committer 2017-01-29 01:38:05 UTC
- update to new upstream bugfix release 2.2.2
ChangeLog: <https://github.com/darktable-org/darktable/releases/tag/release-2.2.2>

- use libomp as a lighter-weight run-time dependency, not LLVM3.7. For this to work, the ABI version .0 needs to be added (else poudriere might not pull it in).

- change COMPILER_TYPE to CHOSEN_COMPILER_TYPE, see Bugzilla #199098
Comment 1 Matthias Andree freebsd_committer 2017-01-29 12:43:50 UTC
Created attachment 179393 [details]
patch against ports/graphics/darktable for update to 2.2.2 with assorted other fixes
Comment 2 Jean-Sébastien Pédron freebsd_committer 2017-01-30 12:42:12 UTC
Thanks!

I adapted your patch to an existing review in Phabricator:
https://reviews.freebsd.org/D9363
Comment 3 commit-hook freebsd_committer 2017-01-30 21:14:36 UTC
A commit references this bug:

Author: dumbbell
Date: Mon Jan 30 21:14:24 UTC 2017
New revision: 432871
URL: https://svnweb.freebsd.org/changeset/ports/432871

Log:
  graphics/darktable: Update to 2.2.2

  Use devel/openmp to provide OpenMP runtime instead of the entire LLVM
  (submitted by mandree@). This allows to use LLVM 3.9 at build time,
  without fearing any dependency to multiple LLVM versions at runtime
  (Mesa pulls LLVM 3.7 for instance).

  Change `COMPILER_TYPE` to `CHOSEN_COMPILER_TYPE`, (submitted by
  mandree@). This was blocking bug 199098.

  Include the following patch from upstream, which fixes a regression
  (suggested by upstream):
  https://github.com/darktable-org/darktable/commit/f7bc2b3338832a42629cdfaa691b5c921df0701c.patch

  PR:		216561
  Submitted by:	mandree (CHOSEN_COMPILER_TYPE and devel/openmp dep.)
  Approved by:	bapt (mentor)
  Differential Revision:	https://reviews.freebsd.org/D9363

Changes:
  head/graphics/darktable/Makefile
  head/graphics/darktable/distinfo
  head/graphics/darktable/files/patch-src_CMakeLists.txt
  head/graphics/darktable/files/patch-src_develop_imageop__math.c