Bug 216618 - biology/plinkseq: fails to build with clang 4.0
Summary: biology/plinkseq: fails to build with clang 4.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords: needs-patch
Depends on:
Blocks: 216008
  Show dependency treegraph
 
Reported: 2017-01-30 22:22 UTC by Jan Beich
Modified: 2017-02-27 14:11 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (jwb)


Attachments
Unified diff (783 bytes, patch)
2017-02-20 16:23 UTC, Jason W. Bacon
jwb: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2017-01-30 22:22:31 UTC
sources/lib/r8lib.cpp:31831:15: error: ordered comparison between pointer and zero ('int *' and 'int')
    if ( i_hi < 0 )
         ~~~~ ^ ~

build log: http://package18.nyi.freebsd.org/data/headamd64PR216008-default/2017-01-29_16h09m05s/logs/errors/plinkseq-0.10.log
regressed by: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3
Comment 1 Jason W. Bacon freebsd_committer 2017-02-20 16:23:04 UTC
Created attachment 180168 [details]
Unified diff

Please try this patch.  Thanks...
Comment 2 commit-hook freebsd_committer 2017-02-27 14:10:08 UTC
A commit references this bug:

Author: jbeich
Date: Mon Feb 27 14:09:25 UTC 2017
New revision: 434941
URL: https://svnweb.freebsd.org/changeset/ports/434941

Log:
  biology/plinkseq: unbreak with clang 4.0

  PR:		216618
  Submitted by:	Jason Bacon <bacon4000@gmail.com> (maintainer)

Changes:
  head/biology/plinkseq/Makefile
  head/biology/plinkseq/files/
  head/biology/plinkseq/files/patch-sources_plinkseq_sources_lib_r8lib.cpp