Bug 216620 - games/libretro-cores: fails to build with clang 4.0
Summary: games/libretro-cores: fails to build with clang 4.0
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords: needs-patch
Depends on:
Blocks: 216008
  Show dependency tree / graph
 
Reported: 2017-01-30 22:27 UTC by Jan Beich
Modified: 2018-01-28 01:28 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (yuri)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2017-01-30 22:27:22 UTC 
src/burn/drv/neogeo/d_neogeo.cpp:1221:27: error: ordered comparison between pointer and zero ('UINT32 *' (aka 'unsigned int *') and 'int')
        if (nNeoSMARNGAddress[0] > 0 || nNeoSMARNGAddress[1] > 0) {
            ~~~~~~~~~~~~~~~~~~~~ ^ ~
src/burn/drv/neogeo/d_neogeo.cpp:1221:55: error: ordered comparison between pointer and zero ('UINT32 *' (aka 'unsigned int *') and 'int')
        if (nNeoSMARNGAddress[0] > 0 || nNeoSMARNGAddress[1] > 0) {
                                        ~~~~~~~~~~~~~~~~~~~~ ^ ~

build log: http://package18.nyi.freebsd.org/data/headamd64PR216008-default/2017-01-29_16h09m05s/logs/errors/libretro-cores-0.20151110_2.log
regressed by: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3
Comment 1 Yuri Victorovich freebsd_committer 2017-01-30 22:37:05 UTC 
See the yet uncommitted update bug#214352 It may or may not change there.

games/libretro-cores combines a lot of code from various sources. I think all parts come from github, usually owned by LibRetro team there. Generally, bugs for such errors need to be reported there, and patches need to be added to the port.
Comment 2 Jan Beich freebsd_committer 2017-01-30 22:58:32 UTC 
(In reply to Yuri Victorovich from comment #1)
> See the yet uncommitted update bug#214352 It may or may not change there.

It doesn't help: http://slexy.org/view/s20PCr3vIr

> Generally, bugs for such errors need to be reported there, and patches
> need to be added to the port.

Sorry, I'm only trying to warn maintainers about pending bustage on 12.0
and 11.1 (usual MFC is 1 month) but have no time to track each upstream
of ports I don't even use.
Comment 3 Yuri Victorovich freebsd_committer 2017-01-30 23:09:02 UTC 
Ok, thanks!
Comment 4 Rene Ladan freebsd_committer 2018-01-28 01:28:44 UTC 
Expired port removed.