Bug 216634 - science/paraview: fails to build with clang 4.0
Summary: science/paraview: fails to build with clang 4.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jason W. Bacon
URL:
Keywords: needs-patch
Depends on:
Blocks: 216008
  Show dependency treegraph
 
Reported: 2017-01-30 23:37 UTC by Jan Beich
Modified: 2018-01-23 09:31 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (devel)


Attachments
patch for files/ (803 bytes, patch)
2017-04-06 08:13 UTC, devel
no flags Details | Diff
Unified diff (5.78 KB, patch)
2017-12-11 17:18 UTC, Jason W. Bacon
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2017-01-30 23:37:29 UTC
VTK/ThirdParty/xdmf2/vtkxdmf2/libsrc/XdmfDsmComm.cxx:55:18: error: ordered comparison between pointer and zero ('void *' and 'int')
    if(Msg->Data <= 0 ){
       ~~~~~~~~~ ^  ~
VTK/ThirdParty/xdmf2/vtkxdmf2/libsrc/XdmfDsmComm.cxx:69:18: error: ordered comparison between pointer and zero ('void *' and 'int')
    if(Msg->Data <= 0 ){
       ~~~~~~~~~ ^  ~

build log: http://package18.nyi.freebsd.org/data/headamd64PR216008-default/2017-01-29_16h09m05s/logs/errors/paraview-5.2.0.log
regressed by: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3
Comment 1 devel 2017-04-06 08:13:03 UTC
Created attachment 181537 [details]
patch for files/

Here is the fix.
Comment 2 Tobias C. Berner freebsd_committer 2017-08-31 11:25:50 UTC
There's an upstream fix for this:

https://github.com/Kitware/VTK/commit/33631146a85dfa64433c3997f166cbaa96bedee9.patch
Comment 3 Jason W. Bacon freebsd_committer 2017-12-11 16:24:18 UTC
Sorry to see this bug has languished for so long.

I'm a new committer and will take this on as soon as my bugtracker account is updated.

In the meantime, can you update the patch set?  This fix alone does not appear to be sufficient anymore.  I'm seeing additional build errors on 11.1-RELEASE.
Comment 4 Jason W. Bacon freebsd_committer 2017-12-11 17:18:55 UTC
Created attachment 188723 [details]
Unified diff

This patch set fixes the build on 11.1-RELEASE.

It would probably be better to fix the MSCPP_EXTRA definition rather than simply remove it, but this is a step forward.

Also added a couple improvements based on port check messages.
Comment 5 commit-hook freebsd_committer 2017-12-13 03:35:00 UTC
A commit references this bug:

Author: jwb
Date: Wed Dec 13 03:34:37 UTC 2017
New revision: 456189
URL: https://svnweb.freebsd.org/changeset/ports/456189

Log:
  science/paraview: Unbreak build with clang 4.0

  PR:		216634
  Submitted by:	Jan Beich
  Approved by:	jrm (mentor), maintainer timeout (3.5 months)
  Differential Revision:	https://reviews.freebsd.org/D13462

Changes:
  head/science/paraview/Makefile
  head/science/paraview/files/patch-Plugins_CDIReader_cdilib.c
  head/science/paraview/files/patch-VTK_ThirdParty_netcdf_vtknetcdf_cxx_ncvalues.h
  head/science/paraview/files/patch-VTK_ThirdParty_netcdf_vtknetcdf_cxx_netcdfcpp.h
  head/science/paraview/files/patch-VTK_ThirdParty_xdmf2_vtkxdmf2_libsrc_XdmfDsmComm.cxx
Comment 6 Walter Schwarzenfeld freebsd_triage 2018-01-23 02:17:42 UTC
Forgotten to close?