Bug 216673 - net/dhcp6: rcorder incorrect
Summary: net/dhcp6: rcorder incorrect
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-31 12:05 UTC by Tim Bishop
Modified: 2018-09-02 21:15 UTC (History)
1 user (show)

See Also:
pi: maintainer-feedback-


Attachments
Possible fix. (802 bytes, patch)
2017-01-31 12:05 UTC, Tim Bishop
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Bishop freebsd_committer 2017-01-31 12:05:45 UTC
Created attachment 179475 [details]
Possible fix.

This port has the following settings for rcorder:

# PROVIDE: dhcp6c
# REQUIRE: DAEMON
# BEFORE: NETWORKING
# KEYWORD: shutdown

# PROVIDE: dhcp6s
# REQUIRE: DAEMON
# BEFORE: NETWORKING
# KEYWORD: shutdown

This tells rcorder to put dhcp6{c,s} after DAEMON and before NETWORKING. So, eg:

DAEMON
dhcp6c
dhcp6s
NETWORKING

Unfortunately, this conflicts with DAEMON:

# PROVIDE: DAEMON
# REQUIRE: NETWORKING SERVERS

Which requires that NETWORKING come before DAEMON. The following error is produced by rcorder:

rcorder: Circular dependency on provision `DAEMON' in file `/usr/local/etc/rc.d/dhcp6c'.
rcorder: Circular dependency on provision `DAEMON' in file `/usr/local/etc/rc.d/dhcp6s'.

As a fix I'd suggest just removing the requirement on DAEMON, since running before NETWORKING seems more important.

This was introduced in bug #169138, so has been this way for nearly 4 years!
Comment 1 Kurt Jaeger freebsd_committer 2018-09-02 21:01:38 UTC
Committed, thanks.
Comment 2 commit-hook freebsd_committer 2018-09-02 21:02:42 UTC
A commit references this bug:

Author: pi
Date: Sun Sep  2 21:02:11 UTC 2018
New revision: 478819
URL: https://svnweb.freebsd.org/changeset/ports/478819

Log:
  net/dhcp6: several fixes

  - rcorder incorrect (Circular dependency on provision `DAEMON')
  - command_flags do not need to be referenced inside of the command_args
  - dhcp6s exits because of shutdown on non-connected UDP socket

  PR:		216673, 217452, 228994
  Submitted by:	tdb, Andrey Pevnev <apevnev@me.com>, leres, Dries Michiels <driesm.michiels@gmail.com>
  Approved by:	hrs (maintainer timeout)
  Differential Revision:	D16994

Changes:
  head/net/dhcp6/Makefile
  head/net/dhcp6/files/dhcp6c.in
  head/net/dhcp6/files/dhcp6s.in
  head/net/dhcp6/files/patch-dhcp6s.c
Comment 3 Tim Bishop freebsd_committer 2018-09-02 21:12:01 UTC
Unless I'm missing something, the change in this bug wasn't actually in the commit?
Comment 4 commit-hook freebsd_committer 2018-09-02 21:14:57 UTC
A commit references this bug:

Author: pi
Date: Sun Sep  2 21:14:48 UTC 2018
New revision: 478821
URL: https://svnweb.freebsd.org/changeset/ports/478821

Log:
  net/dhcp6: really fix the rcorder

  - ups, missed that one

  PR:		216673
  Submitted by:	tdb

Changes:
  head/net/dhcp6/files/dhcp6c.in
  head/net/dhcp6/files/dhcp6s.in
Comment 5 Kurt Jaeger freebsd_committer 2018-09-02 21:15:41 UTC
(In reply to Tim Bishop from comment #3)
Yes, you're right. Fixed. I used the diff from the review and did not check.