Bug 216779 - [NEW PORT] sysutils/acmetool: CLI tool for automatically acquiring certificates from ACME servers
Summary: [NEW PORT] sysutils/acmetool: CLI tool for automatically acquiring certificat...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joseph Mingrone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-04 13:09 UTC by Oleksii Samorukov
Modified: 2017-04-05 13:01 UTC (History)
3 users (show)

See Also:


Attachments
Port tgz (3.40 KB, application/x-gzip)
2017-02-04 13:09 UTC, Oleksii Samorukov
no flags Details
shell archive of sysutils/acmetools (8.93 KB, text/plain)
2017-03-10 17:50 UTC, Chris Hutchinson
no flags Details
shell archive of security/acmetools v.2 (use security category) (8.93 KB, text/plain)
2017-03-13 22:45 UTC, Chris Hutchinson
no flags Details
Acmetool v3 (issue with goyaml fetch fixed) (8.94 KB, text/plain)
2017-04-05 07:42 UTC, Oleksii Samorukov
no flags Details
acmetool v0.59 (8.95 KB, text/plain)
2017-04-05 07:59 UTC, Oleksii Samorukov
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Oleksii Samorukov freebsd_committer freebsd_triage 2017-02-04 13:09:16 UTC
Created attachment 179594 [details]
Port tgz

This is a port for the ACME client from https://github.com/hlandau/acme. This client is already provided binaries for the FreeBSD, but i believe that it is good to have it as FreeBSD native port instead.
Comment 1 Chris Hutchinson 2017-03-10 17:50:00 UTC
Created attachment 180702 [details]
shell archive of sysutils/acmetools

Hello, samm!
I'm looking forward to this hitting the ports tree.
Last I checked the porters handbook:
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/
the preferred method for submitting a new port, was as a
shell archive shar(1). In an effort to expedite your ports
acceptance, I'm submitting a shar(1) version of your port.
I've also taken the liberty of re-flowing the test in a
couple of the files, in an effort to prevent line wrapping.
I also added the sub-category www.
All of this was in an effort to help get your port into the
tree faster. If you like it; simply mark your .tgz file as
obsolete.

All the best.

Thanks samm!

--Chris
Comment 2 Victor 2017-03-13 19:30:18 UTC
This should be changed to security/acmetools. Other ACME utilities, i.e. security/acme-client and security/py-certbot, are categorized under security/.
Comment 3 Chris Hutchinson 2017-03-13 22:45:18 UTC
Created attachment 180795 [details]
shell archive of security/acmetools v.2 (use security category)

Good point Victor!

So noted in the (new) attached shar(1).

Also removed the www sub category. It's trivial
enough to add any sub categories at a later date,
is so warranted.

Thanks!

--Chris
Comment 4 Oleksii Samorukov freebsd_committer freebsd_triage 2017-03-30 16:33:10 UTC
Any chance to see it committed? Its here from the  2017-02-04...
Comment 5 Chris Hutchinson 2017-03-30 16:48:41 UTC
(In reply to samm from comment #4)
> Any chance to see it committed? Its here from the  2017-02-04...

I'd *love* to see that happen!

Given you opened this pr(1). If you could mark the archive
you submitted as "obsolete". That would eliminate any confusion
as to which patch should be approved/committed.

Thank, again, samm!

--Chris

P.S. I'm a maintainer, not a committer. :-)
Comment 6 Oleksii Samorukov freebsd_committer freebsd_triage 2017-03-31 14:08:01 UTC
(In reply to Chris Hutchinson from comment #5)

Done, thank you. I am using this tool on many my FreeBSD servers, including ARM-based one (RPi). I had all kind of problems with official python client, and this tool "just works". So really want to see it in the tree to avoid garbage in the /opt/ directory.
Comment 7 Chris Hutchinson 2017-03-31 17:34:30 UTC
(In reply to samm from comment #6)
> (In reply to Chris Hutchinson from comment #5)
> 
> Done, thank you. I am using this tool on many my FreeBSD servers, including
> ARM-based one (RPi). I had all kind of problems with official python client,
> and this tool "just works". So really want to see it in the tree to avoid
> garbage in the /opt/ directory.

Me too!
Thanks for tending to this. Can't wait for it's
inclusion into the ports tree! :-)

--Chris
Comment 8 Mathieu Arnold freebsd_committer freebsd_triage 2017-04-04 18:52:35 UTC
You are abusing USE_GITHUB=nodefault, use USE_GITHUB=yes instead.

Remove the first line of GH_TUPLE.

After PORTVERSION, set:

DISTVERSIONPREFIX=  v

then set:

GH_ACCOUNT=hlandau
GH_SUBDIR=src/github.com/hlandau/acme
Comment 9 Oleksii Samorukov freebsd_committer freebsd_triage 2017-04-05 07:39:13 UTC
Hi Arnold, i tried to follow your advice and it is failed on fetch 

(=> Attempting to fetch https://codeload.github.com/hlandau/acmetool/tar.gz/v0.0.58?dummy=/hlandau-acmetool-v0.0.58_GH0.tar.gz). 

I still think that nodefault is a good idea, because we are fetching many different repositories. I was trying to workaround this but it was not working for me, so any help is appreciated. 

P.S. I also did a minor fixes in the port, new shar is attached, please use it as base.
Comment 10 Oleksii Samorukov freebsd_committer freebsd_triage 2017-04-05 07:42:07 UTC
Created attachment 181501 [details]
Acmetool v3 (issue with goyaml fetch fixed)
Comment 11 Oleksii Samorukov freebsd_committer freebsd_triage 2017-04-05 07:59:47 UTC
Created attachment 181502 [details]
acmetool v0.59

Update shar to the latest version
Comment 12 Joseph Mingrone freebsd_committer freebsd_triage 2017-04-05 11:46:53 UTC
Minor changes: https://reviews.freebsd.org/D10280

Look OK?
Comment 13 Oleksii Samorukov freebsd_committer freebsd_triage 2017-04-05 12:53:00 UTC
Looks good, thank you!
Comment 14 commit-hook freebsd_committer freebsd_triage 2017-04-05 13:00:21 UTC
A commit references this bug:

Author: jrm
Date: Wed Apr  5 13:00:03 UTC 2017
New revision: 437781
URL: https://svnweb.freebsd.org/changeset/ports/437781

Log:
  New port, security/acmetool: An automatic certificate acquisition tool for
  ACME (Let's Encrypt)

  WWW: https://github.com/hlandau/acme

  PR:		216779
  Submitted by:	samm@os2.kiev.ua (maintainer)
  Reviewed by:	mat
  Approved by:	swills (mentor, implicit)
  Differential Revision:	https://reviews.freebsd.org/D10280

Changes:
  head/security/Makefile
  head/security/acmetool/
  head/security/acmetool/Makefile
  head/security/acmetool/distinfo
  head/security/acmetool/pkg-descr
  head/security/acmetool/pkg-message
  head/security/acmetool/pkg-plist
Comment 15 Joseph Mingrone freebsd_committer freebsd_triage 2017-04-05 13:01:38 UTC
Committed.  Thanks.