Bug 216791 - graphics/graphviz: Option dependencies
Summary: graphics/graphviz: Option dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dirk Meyer
URL: https://forums.freebsd.org/threads/59...
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-02-04 20:18 UTC by Tobias Kortkamp
Modified: 2017-02-09 10:23 UTC (History)
1 user (show)

See Also:
dinoex: maintainer-feedback+

Attachments
graphics___graphviz.diff (3.03 KB, patch)
2017-02-04 20:18 UTC, Tobias Kortkamp 		tobik: maintainer-approval? (dinoex)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2017-02-04 20:18:03 UTC 
Created attachment 179609 [details]
graphics___graphviz.diff

The port option TK requires that TCL is enabled.  Currently the port enforces this by setting IGNORE when TK=on and TCL=off.  Is it possible to switch to using TK_IMPLIES=TCL instead?  This way the required option would be automatically enabled.

There are more options that do the same.  I've tried to switch them all to using IMPLIES.
Comment 1 Dirk Meyer freebsd_committer freebsd_triage 2017-02-08 06:54:28 UTC 
in test for regressions with e.G. WITHOUT_TCL
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-02-09 09:56:08 UTC 
A commit references this bug:

Author: dinoex
Date: Thu Feb  9 09:55:25 UTC 2017
New revision: 433718
URL: https://svnweb.freebsd.org/changeset/ports/433718

Log:
  - use *_IMPLIES
  PR:		216791
  Submitted by:	Tobias Kortkamp

Changes:
  head/graphics/graphviz/Makefile
Comment 3 Dirk Meyer freebsd_committer freebsd_triage 2017-02-09 10:23:40 UTC 
not documented:
but IMPLIES overwrites any WITHOUT_* or OPTIONS_UNSET=*