Bug 216815 - [PATCH] multimedia/assimp: Fix build on armv6 and aarch64
Summary: [PATCH] multimedia/assimp: Fix build on armv6 and aarch64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Kirill Ponomarev
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-02-05 09:57 UTC by Michal Meloun
Modified: 2017-02-09 17:59 UTC (History)
3 users (show)

See Also:
yuri: maintainer-feedback+

Attachments
BlenderDNA.cpp fix (1.07 KB, text/plain)
2017-02-05 09:57 UTC, Michal Meloun 		no flags Details
Unbreak armv6 and aarch64 (563 bytes, patch)
2017-02-05 09:58 UTC, Michal Meloun 		no flags Details | Diff
Fix build on armv6 and aarch64 (2.26 KB, patch)
2017-02-06 07:32 UTC, Michal Meloun 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Meloun freebsd_committer freebsd_triage 2017-02-05 09:57:15 UTC 
Created attachment 179630 [details]
BlenderDNA.cpp fix

Attached patch fixes build on armv6. I think that it also fixes aarcch64, but unfortunately I haven't prepared infrastructure to test it.
Comment 1 Michal Meloun freebsd_committer freebsd_triage 2017-02-05 09:58:02 UTC 
Created attachment 179631 [details]
Unbreak armv6 and aarch64
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2017-02-05 10:00:05 UTC 
You need to make it into one patch. BlenderDNA.cpp fix should be in files/ ?
Comment 3 Michal Meloun freebsd_committer freebsd_triage 2017-02-05 10:29:26 UTC 
Ahh, sorry, next time I'll do it in this way.
Yes, BlenderDNA.cpp fix should be in files.
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2017-02-05 18:43:42 UTC 
You need to attach a single patch to commit contains both changes, and obsolete the first two patches.
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2017-02-05 21:12:42 UTC 
You need to attach a single patch that can be committed that contains both changes.

Please also mark the first two patches obsolete.
Comment 6 Michal Meloun freebsd_committer freebsd_triage 2017-02-06 07:32:13 UTC 
Created attachment 179668 [details]
Fix build on armv6 and aarch64

Join both patches into single one.
Comment 7 Yuri Victorovich freebsd_committer freebsd_triage 2017-02-06 07:46:41 UTC 
Passes poudriere.
No need to bump PORTREVISION, since it only unbreaks certain architectures.
Comment 8 commit-hook freebsd_committer freebsd_triage 2017-02-09 17:41:53 UTC 
A commit references this bug:

Author: krion
Date: Thu Feb  9 17:41:19 UTC 2017
New revision: 433750
URL: https://svnweb.freebsd.org/changeset/ports/433750

Log:
  Unbreak multimedia/assimp on armv6 and aarch64

  PR:		216815
  Submitted by:	mmel@FreeBSD.org
  Approved by:	mag (mentor)
  Differential Revision:	https://reviews.freebsd.org/D9489

Changes:
  head/multimedia/assimp/Makefile
  head/multimedia/assimp/files/patch-code_BlenderDNA.cpp