Bug 216981 - Missing include in sys/arm64/include/atomic.h
Summary: Missing include in sys/arm64/include/atomic.h
Status: Closed Not A Bug
Alias: None
Product: Base System
Classification: Unclassified
Component: arm (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-arm (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-10 22:02 UTC by karl
Modified: 2017-02-10 22:15 UTC (History)
1 user (show)

See Also:

Attachments
Add the missing include.... (437 bytes, text/plain)
2017-02-10 22:02 UTC, karl 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description karl 2017-02-10 22:02:52 UTC 
Created attachment 179856 [details]
Add the missing include....

#include <sys/types.h> is missing, and thus inclusion of this header file results in compile failures due to lack of declaration of the various types specified inside.
Comment 1 Ian Lepore freebsd_committer freebsd_triage 2017-02-10 22:12:45 UTC 
This is not a bug.  Per atomic(9), users of atomic.h are required to include sys/types.h before machine/atomic.h.
Comment 2 karl 2017-02-10 22:13:50 UTC 
(In reply to Ian Lepore from comment #1)

Interesting, considering that the same include file in the arm architecture DOES include it internally!  I'd argue it ought to be removed from the other architectures if this is the case (and expect kernel builds to immediately break if you do!)
Comment 3 Ian Lepore freebsd_committer freebsd_triage 2017-02-10 22:15:11 UTC 
The fact that arm has #include <types.h> just means that arm is wrong.  I think every other arch gets it right.