Bug 217013 - security/certificate-transparency: Fix build issues with LibreSSL
Summary: security/certificate-transparency: Fix build issues with LibreSSL
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Bernard Spil
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-11 21:19 UTC by Bernard Spil
Modified: 2017-04-02 14:24 UTC (History)
1 user (show)

See Also:


Attachments
svn diff for security/certificate-transparency (8.47 KB, patch)
2017-02-11 21:19 UTC, Bernard Spil
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bernard Spil freebsd_committer 2017-02-11 21:19:08 UTC
Created attachment 179883 [details]
svn diff for security/certificate-transparency

security/certificate-transparency: Fix build issues with LibreSSL

  - Fix OPENSSL_VERSION_NUMBER checks
  - Fix LibreSSL detection
  - Modify CMS disabling to BoringSSL and LibreSSL

Upstream: https://github.com/google/certificate-transparency/pull/1364

PR: 
Submitted by: brnrd
Comment 1 Martin Wilke freebsd_committer 2017-02-24 20:37:06 UTC
Submitter is committer.
Comment 2 commit-hook freebsd_committer 2017-03-26 10:40:57 UTC
A commit references this bug:

Author: brnrd
Date: Sun Mar 26 10:40:49 UTC 2017
New revision: 436952
URL: https://svnweb.freebsd.org/changeset/ports/436952

Log:
  security/certificate-transparency: Fix build issues with LibreSSL

    - Fix OPENSSL_VERSION_NUMBER checks
    - Fix LibreSSL detection
    - Modify CMS disabling to BoringSSL and LibreSSL

  PR:		217013
  Obtained from:	https://github.com/google/certificate-transparency/pull/1364

Changes:
  head/security/certificate-transparency/files/patch-Makefile.am
  head/security/certificate-transparency/files/patch-configure.ac
  head/security/certificate-transparency/files/patch-cpp-client-ct.cc
  head/security/certificate-transparency/files/patch-cpp_client_ssl__client.cc
  head/security/certificate-transparency/files/patch-cpp_log_cert.cc
Comment 3 Jan Beich freebsd_committer 2017-04-02 09:57:37 UTC
Backed out in ports r436952 for bustage:

cpp/client/ct.cc:454:38: error: no member named 'ProgramUsage' in namespace 'google'; did you mean 'gflags::ProgramUsage'?
  CHECK(!FLAGS_sct_token.empty()) << google::ProgramUsage();
                                     ^~~~~~~~~~~~~~~~~~~~
                                     gflags::ProgramUsage
/usr/local/include/gflags/gflags.h:197:36: note: 'gflags::ProgramUsage' declared here
extern GFLAGS_DLL_DECL const char* ProgramUsage();                 // string set by SetUsageMessage()
                                   ^
cpp/client/ct.cc:455:50: error: no member named 'ProgramUsage' in namespace 'google'; did you mean 'gflags::ProgramUsage'?
  CHECK(!FLAGS_extensions_config_out.empty()) << google::ProgramUsage();
                                                 ^~~~~~~~~~~~~~~~~~~~
                                                 gflags::ProgramUsage
/usr/local/include/gflags/gflags.h:197:36: note: 'gflags::ProgramUsage' declared here
extern GFLAGS_DLL_DECL const char* ProgramUsage();                 // string set by SetUsageMessage()
                                   ^
cpp/client/ct.cc:482:38: error: no member named 'ProgramUsage' in namespace 'google'; did you mean 'gflags::ProgramUsage'?
  CHECK(!FLAGS_sct_token.empty()) << google::ProgramUsage();
                                     ^~~~~~~~~~~~~~~~~~~~
                                     gflags::ProgramUsage
/usr/local/include/gflags/gflags.h:197:36: note: 'gflags::ProgramUsage' declared here
extern GFLAGS_DLL_DECL const char* ProgramUsage();                 // string set by SetUsageMessage()
                                   ^
cpp/client/ct.cc:483:51: error: no member named 'ProgramUsage' in namespace 'google'; did you mean 'gflags::ProgramUsage'?
  CHECK(!FLAGS_tls_extension_data_out.empty()) << google::ProgramUsage();
                                                  ^~~~~~~~~~~~~~~~~~~~
                                                  gflags::ProgramUsage
/usr/local/include/gflags/gflags.h:197:36: note: 'gflags::ProgramUsage' declared here
extern GFLAGS_DLL_DECL const char* ProgramUsage();                 // string set by SetUsageMessage()
                                   ^
cpp/client/ct.cc:942:3: error: no member named 'SetUsageMessage' in namespace 'google'; did you mean 'gflags::SetUsageMessage'?
  google::SetUsageMessage(argv[0] + string(kUsage));
  ^~~~~~~~~~~~~~~~~~~~~~~
  gflags::SetUsageMessage
/usr/local/include/gflags/gflags.h:333:29: note: 'gflags::SetUsageMessage' declared here
extern GFLAGS_DLL_DECL void SetUsageMessage(const std::string& usage);
                            ^
cpp/client/ct.cc:948:18: error: no member named 'ProgramUsage' in namespace 'google'; did you mean 'gflags::ProgramUsage'?
    std::cout << google::ProgramUsage();
                 ^~~~~~~~~~~~~~~~~~~~
                 gflags::ProgramUsage
/usr/local/include/gflags/gflags.h:197:36: note: 'gflags::ProgramUsage' declared here
extern GFLAGS_DLL_DECL const char* ProgramUsage();                 // string set by SetUsageMessage()
                                   ^
cpp/client/ct.cc:986:18: error: no member named 'ProgramUsage' in namespace 'google'; did you mean 'gflags::ProgramUsage'?
    std::cout << google::ProgramUsage();
                 ^~~~~~~~~~~~~~~~~~~~
                 gflags::ProgramUsage
/usr/local/include/gflags/gflags.h:197:36: note: 'gflags::ProgramUsage' declared here
extern GFLAGS_DLL_DECL const char* ProgramUsage();                 // string set by SetUsageMessage()
                                   ^
7 errors generated.

http://package19.nyi.freebsd.org/data/103i386-default-build-as-user/437337/logs/errors/certificate-transparency-20161015_8.log
Comment 4 Jan Beich freebsd_committer 2017-04-02 09:58:36 UTC
(In reply to Jan Beich from comment #3)
> Backed out in ports r436952 for bustage:

Typo: backed out in ports r437393