Bug 217079 - x11/konsole: fails to build on armv6
Summary: x11/konsole: fails to build on armv6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Many People
Assignee: freebsd-kde (group)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-13 18:33 UTC by Mikael Urankar
Modified: 2017-06-02 19:38 UTC (History)
2 users (show)

See Also:
tcberner: maintainer-feedback+

Attachments
patch (974 bytes, patch)
2017-02-13 18:33 UTC, Mikael Urankar 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Urankar freebsd_committer freebsd_triage 2017-02-13 18:33:06 UTC 
Created attachment 179956 [details]
patch

error:

[ 27%] Building CXX object src/CMakeFiles/konsoleprivate.dir/ColorScheme.o
cd /wrkdirs/usr/ports/x11/konsole/work/.build/src && /nxb-bin/usr/bin/c++   -DKDE4_CMAKE_TOPLEVEL_DIR_LENGTH=35 -DKDE_DEFAULT_DEBUG_AREA=1211 -DKDE_DEPRECATED_WARNINGS -DMAKE_KONSOLEPRIVATE_LIB -DQT_NO_CAST_TO_ASCII -DQT_NO_STL -DQT_USE_FAST_CONCATENATION -DQT_USE_FAST_OPERATOR_PLUS -D_REENTRANT -I/wrkdirs/usr/ports/x11/konsole/work/.build/src -I/wrkdirs/usr/ports/x11/konsole/work/konsole-4.14.3/src -I/wrkdirs/usr/ports/x11/konsole/work/konsole-4.14.3 -I/wrkdirs/usr/ports/x11/konsole/work/.build -I/usr/local/include/kde4 -I/usr/local/include/kde4/KDE -I/usr/local/include/KDE -I/usr/local/include -I/usr/local/include/qt4/phonon -I/usr/local/include/qt4/QtXmlPatterns -I/usr/local/include/qt4/QtXml -I/usr/local/include/qt4/QtWebKit -I/usr/local/include/qt4/QtTest -I/usr/local/include/qt4/QtSvg -I/usr/local/include/qt4/QtSql -I/usr/local/include/qt4/QtScript -I/usr/local/include/qt4/QtOpenGL -I/usr/local/include/qt4/QtNetwork -I/usr/local/include/qt4/QtDeclarative -I/usr/local/include/qt4/QtDBus -I/usr/local/include/qt4/Qt3Support -I/usr/local/include/qt4/QtGui -I/usr/local/include/qt4/QtCore -I/usr/local/include/qt4/Qt -I/usr/local/share/qt4/mkspecs/default -I/usr/local/include/qt4 -O2 -pipe -fno-builtin-sin -fno-builtin-cos -fno-strict-aliasing -fno-builtin-sin -fno-builtin-cos -Wnon-virtual-dtor -Wno-long-long -Wundef -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith -Wformat-security -Woverloaded-virtual -fno-common -fvisibility=hidden -Werror=return-type -fvisibility-inlines-hidden -Wno-return-type-c-linkage -O2 -DNDEBUG -DQT_NO_DEBUG -fPIC    -D_LARGEFILE64_SOURCE -o CMakeFiles/konsoleprivate.dir/ColorScheme.o -c /wrkdirs/usr/ports/x11/konsole/work/konsole-4.14.3/src/ColorScheme.cpp
/wrkdirs/usr/ports/x11/konsole/work/konsole-4.14.3/src/ColorScheme.cpp:409:9: error: call to 'qFuzzyCompare' is ambiguous
    if (qFuzzyCompare(1.0, opacity)) {
        ^~~~~~~~~~~~~
/usr/local/include/qt4/QtCore/qglobal.h:2156:37: note: candidate function
Q_DECL_CONSTEXPR static inline bool qFuzzyCompare(double p1, double p2)


The attached patch fixes the issue, obtained from mmel@
Comment 1 Mikael Urankar freebsd_committer freebsd_triage 2017-05-31 10:29:18 UTC 
ping
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-06-02 19:36:58 UTC 
A commit references this bug:

Author: tcberner
Date: Fri Jun  2 19:36:46 UTC 2017
New revision: 442456
URL: https://svnweb.freebsd.org/changeset/ports/442456

Log:
  Fix ambiguity of qFuzzyCompare on armv6

  PR:		217079
  Submitted by:	Mika?l Urankar <mikael.urankar@gmail.com>

Changes:
  head/x11/konsole/Makefile
  head/x11/konsole/files/patch-src_ColorScheme.cpp
Comment 3 Tobias C. Berner freebsd_committer freebsd_triage 2017-06-02 19:38:02 UTC 
Thanks for the patience/ch :)