I have ran into a situation where when I do a: service salt_master restart The master does not exit quickly enough and so the start command fails. This patch addresses it by teaching the rc framework the value of the pidfile.
Created attachment 180058 [details] patch
Thanks for the fix.
A commit references this bug: Author: brd Date: Fri Feb 17 15:59:58 UTC 2017 New revision: 434287 URL: https://svnweb.freebsd.org/changeset/ports/434287 Log: sysutils/py-salt: Teach the Salt master and minion startup scripts to set pidfile=. On a restart this will cause the rc framework to wait for the processes to exit before trying to start, instead of failing to start because the previous processes have not gone away yet. PR: 217154 Approved by: Christer Edwards <christer.edwards@gmail.com> (maintainer), bdrewery (mentor, implicit) Changes: head/sysutils/py-salt/Makefile head/sysutils/py-salt/files/salt_master.in head/sysutils/py-salt/files/salt_minion.in
Thanks!
Merged to 2017Q1 quarterly branch. Thanks!
A commit references this bug: Author: woodsb02 Date: Sun Feb 19 02:12:10 UTC 2017 New revision: 434392 URL: https://svnweb.freebsd.org/changeset/ports/434392 Log: MFH: r434287 sysutils/py-salt: Teach the Salt master and minion startup scripts to set pidfile=. On a restart this will cause the rc framework to wait for the processes to exit before trying to start, instead of failing to start because the previous processes have not gone away yet. PR: 217154 Approved by: Christer Edwards <christer.edwards@gmail.com> (maintainer), bdrewery (mentor, implicit) Approved by: ports-secteam (junovitch) Changes: _U branches/2017Q1/ branches/2017Q1/sysutils/py-salt/Makefile branches/2017Q1/sysutils/py-salt/files/salt_master.in branches/2017Q1/sysutils/py-salt/files/salt_minion.in