Bug 217279 - math/openblas: fix build on armv6
Summary: math/openblas: fix build on armv6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Many People
Assignee: Joseph Mingrone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-21 17:36 UTC by Mikael Urankar
Modified: 2017-02-25 18:32 UTC (History)
3 users (show)

See Also:
phd_kimberlite: maintainer-feedback+


Attachments
patch (2.22 KB, patch)
2017-02-21 17:36 UTC, Mikael Urankar
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Urankar freebsd_committer 2017-02-21 17:36:27 UTC
Created attachment 180198 [details]
patch

Hi,

openblas compiles fine with the attached patch, obtained from mmel@

build log:
http://mikael.urankar.free.fr/FreeBSD/arm/build_logs/openblas-0.2.19%2C1.log
Comment 1 Joseph Mingrone freebsd_committer 2017-02-25 16:45:42 UTC
I tested with this (exact) patch in a 11.0-RELEASE r306280 arm.armv6 jail and the build failed.

http://pkg.awarnach.mathstat.dal.ca/data/11armv6-default/2017-02-25_09h14m08s/logs/errors/openblas-0.2.19,1.log

I'm still testing 10armv6.

It does not break 10/11 amd64/i386, so it could still be committed.

While here, some of the code dealing with options could be shortened/simplified by using the newer options framework.  https://reviews.freebsd.org/D9801  The logic is the same and all poudriere runs with default options and other option combinations passed as described in the Phabricator diff.
Comment 2 commit-hook freebsd_committer 2017-02-25 18:20:53 UTC
A commit references this bug:

Author: jrm
Date: Sat Feb 25 18:19:51 UTC 2017
New revision: 434832
URL: https://svnweb.freebsd.org/changeset/ports/434832

Log:
  math/openblas: Fix build on 12-CURRENT armv6.

  The build still fails on 11 armv6, however MFC of r313873 will hopefully
  fix the build there as well.

  While here also add LICENSE_FILE and fix portlint warnings.

  PR:		217279
  Submitted by:	mikael.urankar@gmail.com
  Approved by:	phd_kimberlite@yahoo.co.jp (maintainer), swills (mentor, implicit)
  Differential Revision:	https://reviews.freebsd.org/D9801

Changes:
  head/math/openblas/Makefile
  head/math/openblas/files/patch-common__arm.h
  head/math/openblas/files/patch-cpuid__arm.c
  head/math/openblas/files/patch-interface__ztrmv.c
Comment 3 Joseph Mingrone freebsd_committer 2017-02-25 18:32:21 UTC
Only the patch and the simple, obvious changes have been committed.  I will submit the other changes for maintainer approval.  Thanks.