Bug 217316 - Formalize MAINTAINERS use with Phabricator
Summary: Formalize MAINTAINERS use with Phabricator
Status: New
Alias: None
Product: Services
Classification: Unclassified
Component: Code Review (show other bugs)
Version: unspecified
Hardware: Any Any
: --- Affects Only Me
Assignee: Phabric Admin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-23 23:10 UTC by Enji Cooper
Modified: 2017-04-03 11:30 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Enji Cooper freebsd_committer 2017-02-23 23:10:26 UTC
MAINTAINERS doesn't always get read by humans before commits are made, which suggests (to me) that this could be automated based on the contents of the file from FreeBSD src tree.

I would like to formalize its use with Phabricator -- I just need to know what formats MAINTAINERS needs to be digested as so I can make the necessary conversions (if needed) to make it so.
Comment 1 Allan Jude freebsd_committer 2017-02-24 02:31:52 UTC
Phabricator has a bot, called 'Harold', that can do things like add 'blocking reviewers' automatically.

For some example rules, portmgr has one for the Mk/ directory in ports, and secteam has a few for things like sys/crypto

I am not sure what it would take to automate the process, but it shouldn't be too difficult to convert most or all of the contents of the current file into Harold rules.
Comment 2 Juliette Morgan 2017-04-03 11:30:21 UTC
Hello! I've faced some problems with a bot, called "Harold". This bot seems to have some strange rules in blocking the reviewers. For example, a reviewer is trying to enter a value like http://writingservices.review/ into a form, strictly specified for these needs and he gets blocked. At the same time any other reviewer is trying to enter almost the same values but in a bit different ways like writingservices reviews or writing services.reviews and the bot is OK with that. What's the point?