Created attachment 180294 [details] Proposed patch Update news/sabnzbdplus to version 1.2.1 Also start using GH_TAGNAME for a specific commit so that the master branch is used. Tested with poudriere and portlint
Thanks, I will have time to test today or tomorrow.
Created attachment 180309 [details] patch Add use of shebangfix instead of REINPLACE_CMD
I see a bugfix was released, v1.2.2 also I'm wondering if PORTNAME can be removed from SUB_LIST and if PLIST_SUB can be removed all together? if you have a chance can you test what I mentioned with poudriere? I should have time tomorrow to verify.
Created attachment 180332 [details] sabnzbdplus patch This diff is an iteration of @nahun's diff, and also removes the PORTNAME substitution that is never actually used. It is ok if we commit this now. Though SABnzbd has already released version 1.2.2, but they did not tag it in their master branch so I do not know how we could properly package it.
Comment on attachment 180309 [details] patch Marking my patch obsolete. Also, 1.2.2 only has a fix for Windows so it at least doesn't affect us
yeah, not a big deal. in related news, version 2 has a new optional dependency we can work on getting ported. maybe make yenc a multi-option where you can pick yenc or the new thing.
A commit references this bug: Author: swills Date: Mon Feb 27 18:08:24 UTC 2017 New revision: 434984 URL: https://svnweb.freebsd.org/changeset/ports/434984 Log: news/sabnzbdplus: Update to 1.2.1 PR: 217359 Submitted by: joshruehlig@gmail.com (maintainer) Changes: head/news/sabnzbdplus/Makefile head/news/sabnzbdplus/distinfo
Committed, thanks!
(In reply to Steve Wills from comment #8) Thank you for the quick review. =]