Bug 217497 - [patch] graphics/simpleviewer: install config.example
Summary: [patch] graphics/simpleviewer: install config.example
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-02 15:12 UTC by wjenkner
Modified: 2019-01-26 08:01 UTC (History)
2 users (show)

See Also:

Attachments
0001-Install-config.example.patch (1.44 KB, patch)
2017-03-02 15:15 UTC, wjenkner 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description wjenkner 2017-03-02 15:12:35 UTC 
Perhaps it would be useful to install config.example as well?

Please see the attached patch.
Comment 1 wjenkner 2017-03-02 15:15:12 UTC 
Created attachment 180440 [details]
0001-Install-config.example.patch

install config.example
Comment 2 Alexey Dokuchaev freebsd_committer freebsd_triage 2017-03-02 15:24:07 UTC 
That's probably a good idea, thanks.  I'm currently waiting for the next upstream release that would allow to drop our custom patches, and will likely include your proposal alongside with the "version update" commit.

On a related note, I'm not sure yet if it would would be more appropriate to install example config file not as part of PORTEXAMPLES, but rather as a @sample file under $localbase/etc.
Comment 3 wjenkner 2017-03-02 15:52:03 UTC 
IIUC, you would like to suggest to the upstream author to support
a system-wide config file as well?

Currently, there's no such thing (you likely know this but just in
case other people are reading this...), see cConfig::read in
src/common/config.cpp.
Comment 4 Alexey Dokuchaev freebsd_committer freebsd_triage 2017-03-02 16:00:28 UTC 
I considered proposing it upstream, but then had thought that you might be more appropriate party to suggest it since it's your idea originally. :-)

If you don't have a Bitbucket account, don't bother: in this case I'll probably do it myself after more investigation (thanks for the pointer at where to look).
Comment 5 wjenkner 2017-03-03 02:39:08 UTC 
Thanks.  Actually, I've no strong opinion on the need for a system-wide config,
so I won't pursue this upstream.
Comment 6 Walter Schwarzenfeld freebsd_triage 2018-02-10 14:58:19 UTC 
Status?
Comment 7 Alexey Dokuchaev freebsd_committer freebsd_triage 2018-02-11 02:44:53 UTC 
Undecided (still thinking).
Comment 8 Tobias Kortkamp freebsd_committer freebsd_triage 2019-01-25 21:41:12 UTC 
(In reply to Alexey Dokuchaev from comment #7)
> Undecided (still thinking).

And now?  It has been almost 2 years since this was opened and the request
seems simple enough.  I don't see how this requires much thought.  Why not
just add it to the port as suggested?
Comment 9 commit-hook freebsd_committer freebsd_triage 2019-01-26 08:01:30 UTC 
A commit references this bug:

Author: tobik
Date: Sat Jan 26 08:01:17 UTC 2019
New revision: 491246
URL: https://svnweb.freebsd.org/changeset/ports/491246

Log:
  graphics/simpleviewer: Install config.example

  PR:		217497
  Submitted by:	wjenkner@inode.at

Changes:
  head/graphics/simpleviewer/Makefile
  head/graphics/simpleviewer/files/
  head/graphics/simpleviewer/files/pkg-message.in
Comment 10 Tobias Kortkamp freebsd_committer freebsd_triage 2019-01-26 08:01:55 UTC 
(In reply to Tobias Kortkamp from comment #8)
> (In reply to Alexey Dokuchaev from comment #7)
> > Undecided (still thinking).
> 
> And now?  It has been almost 2 years since this was opened and the request
> seems simple enough.  I don't see how this requires much thought.  Why not
> just add it to the port as suggested?

I was under the mistaken impression that the port has a maintainer
and that this was blocked by danfe@, but since that isn't the case:
Landed.  Thanks!