Bug 217559 - [patch] multimedia/smtube: add Qt5 option, provide a choice between supported video players
Summary: [patch] multimedia/smtube: add Qt5 option, provide a choice between supported...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-03-05 10:07 UTC by Andriy Voskoboinyk
Modified: 2017-03-06 19:28 UTC (History)
1 user (show)

See Also:
pawel: maintainer-feedback+


Attachments
Makefile.diff (1.72 KB, patch)
2017-03-05 10:07 UTC, Andriy Voskoboinyk
no flags Details | Diff
Poudriere logs (10.3-RELEASE i386, 11.0-RELEASE amd64) (14.47 KB, application/x-xz)
2017-03-05 10:13 UTC, Andriy Voskoboinyk
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andriy Voskoboinyk freebsd_committer 2017-03-05 10:07:58 UTC
Created attachment 180529 [details]
Makefile.diff

- Add Qt5 / Qt4 radio-choice.
- Allow to add MPlayer / mpv / VLC / SMPlayer as a runtime dependency for video playback.
- Bump PORTREVISION.
Comment 1 Andriy Voskoboinyk freebsd_committer 2017-03-05 10:10:55 UTC
(multimedia/gnome-mplayer does not play videos from smtube out-of-the-box, so it is omitted from the list for now)
Comment 2 Andriy Voskoboinyk freebsd_committer 2017-03-05 10:13:15 UTC
Created attachment 180530 [details]
Poudriere logs (10.3-RELEASE i386, 11.0-RELEASE amd64)

(warnings about libGL are wrong and should go away when compiled with LDFLAGS=-Wl,--as-needed + non-broken compiler (clang ignores this option))
Comment 3 commit-hook freebsd_committer 2017-03-06 19:28:56 UTC
A commit references this bug:

Author: pawel
Date: Mon Mar  6 19:27:57 UTC 2017
New revision: 435565
URL: https://svnweb.freebsd.org/changeset/ports/435565

Log:
  - Add Qt5 / Qt4 radio-choice
  - Allow to add MPlayer / mpv / VLC / SMPlayer as a runtime
    dependency for video playback

  PR:		217559
  Submitted by:	avos

Changes:
  head/multimedia/smtube/Makefile