Bug 217565 - [patch] net/wpa_gui: add Qt5 / NLS options
Summary: [patch] net/wpa_gui: add Qt5 / NLS options
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joseph Mingrone
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-03-05 16:19 UTC by Andriy Voskoboinyk
Modified: 2018-06-13 19:27 UTC (History)
1 user (show)

See Also:

Attachments
Makefile.diff (3.07 KB, patch)
2017-03-05 16:19 UTC, Andriy Voskoboinyk 		no flags Details | Diff
Poudriere logs (10.3-RELEASE i386, 11.0-RELEASE amd64) (11.13 KB, application/x-xz)
2017-03-05 16:24 UTC, Andriy Voskoboinyk 		no flags Details
patch to default to Qt5 and other tweaks (2.87 KB, patch)
2018-03-01 21:13 UTC, Joseph Mingrone 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andriy Voskoboinyk freebsd_committer freebsd_triage 2017-03-05 16:19:17 UTC 
Created attachment 180542 [details]
Makefile.diff

- Provide a choice between Qt4 and Qt5 (Qt4 is selected by default).
- Add NLS option (only one localization is installed at the moment).
- Drop suid bit (Qt5 binary will not run with it + wpa_gui(8) seems to work fine even without it (checked with base wpa_supplicant(8)))
- Bump PORTREVISION.
Comment 1 Andriy Voskoboinyk freebsd_committer freebsd_triage 2017-03-05 16:24:43 UTC 
Created attachment 180543 [details]
Poudriere logs (10.3-RELEASE i386, 11.0-RELEASE amd64)

(warnings about libGL are wrong and should go away when compiled with LDFLAGS=-Wl,--as-needed + non-broken compiler (clang ignores this option))
Comment 2 Joseph Mingrone freebsd_committer freebsd_triage 2018-03-01 21:13:48 UTC 
Created attachment 191116 [details]
patch to default to Qt5 and other tweaks
Comment 3 Joseph Mingrone freebsd_committer freebsd_triage 2018-03-01 21:14:23 UTC 
Sorry to see this has not been addressed for so long.  Since Qt4 is no longer supported upstream, what do you think about just defaulting to Qt5?  The attached patch does that (tested) and includes some other tweaks to conform to the 'Order of Variables in Port Makefiles' chapter in the Porter's Handbook.
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-06-13 19:26:33 UTC 
A commit references this bug:

Author: jrm
Date: Wed Jun 13 19:25:37 UTC 2018
New revision: 472340
URL: https://svnweb.freebsd.org/changeset/ports/472340

Log:
  net/wpa_gui: Switch to QT5, add NLS option, cleanup

  PR:		217565
  Submitted by:	avos (in part)

Changes:
  head/net/wpa_gui/Makefile