Bug 217607 - ng_cisco only sends flow control messages to nodes connected via 'inet' hook
Summary: ng_cisco only sends flow control messages to nodes connected via 'inet' hook
Status: New
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 11.0-STABLE
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-net (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-03-07 09:36 UTC by Łukasz Wójcik
Modified: 2017-03-08 01:38 UTC (History)
0 users

See Also:

Attachments
sketch of a patch fixing the issue (948 bytes, patch)
2017-03-07 09:36 UTC, Łukasz Wójcik 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Łukasz Wójcik 2017-03-07 09:36:01 UTC 
Created attachment 180593 [details]
sketch of a patch fixing the issue

ng_cisco's cisco_notify() routine only sends flow control messages to nodes connected via 'inet' hook, completely ignoring those connected via 'inet6'. This poses some problem if peer node relies on link status information passed from ng_cisco. I'd therefore like to suggest a patch (perhaps something similar to what I attached). All it does is to make ng_cisco node pass flow control messages to *both* 'inet' and 'inet6' peers. It seems to me that it is both possible and sensible to expect both mentioned hooks to be connected at the same time.