Bug 217609 - dns/pear-Net_DNS2: Update to 1.4.3
Summary: dns/pear-Net_DNS2: Update to 1.4.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Wen Heping
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-07 12:30 UTC by Jochen Neumeister
Modified: 2017-03-08 02:42 UTC (History)
2 users (show)

See Also:


Attachments
Patch (785 bytes, patch)
2017-03-07 12:30 UTC, Jochen Neumeister
joneum: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jochen Neumeister freebsd_committer freebsd_triage 2017-03-07 12:30:19 UTC
Created attachment 180599 [details]
Patch

Changelog:

- fixed an issue when looking up . or com., when using the strict_query_mode flag.
- fixed a bug in the caching logic where I was loading the content more than once per instance, when really I only need to do it once.
- changed the Net_DNS2::sock array to use the SOCK_DGRAM and SOCK_STREAM defines, rather than the strings 'tcp' or 'udp'.
- fixed a bug in the Net_DNS2_Header and Net_DNS2_Question classes, where I was using the wrong bit-shift operators when parsing some of the values. This only became apparent when somebody was trying to use the CAA class (id 257); it was causing this to roll over to the next 8 bit value, and returning 1 (RR A) instead of the CAA class.
- fixed a bug that occurs when a DNS lookup request times out, and then the same class is reused for a subsequent request. Because I'm caching the sockets, the timed out data could eventually come in, and end up being seen as the result for a subsequent lookup.
- fixed a couple cases in NSAP.php where I was comparing a string to to an integer.

https://pear.php.net/package/Net_DNS2/download/All

poudriere build fine for:
9.3 amd + i386
10.3 amd + i386
12-current amd + i386 (r313761)

portlint is also fine.

Cheers
jochen
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-03-08 02:39:13 UTC
A commit references this bug:

Author: wen
Date: Wed Mar  8 02:38:24 UTC 2017
New revision: 435652
URL: https://svnweb.freebsd.org/changeset/ports/435652

Log:
  - Update to 1.4.3

  PR:		217609
  Submitted by:	joneum@bsdproject.de(maintainer)

Changes:
  head/dns/pear-Net_DNS2/Makefile
  head/dns/pear-Net_DNS2/distinfo