Created attachment 180661 [details]
This PR updates security/bro from 2.4.1 to 2.5. It unbreaks building with BROKER enabled and resolves PR 212433:
security/bro: Add rc script to work with rc.conf
All existing patch files except patch-aux-broker-CMakeLists.txt should be removed.
bro 2.4.1 required devel/caf 0.13.X but devel/caf was upgraded to 0.14.X around the time bro 2.4.1 was release so at the time we used patches to bro that the developers provided.
bro 2.5 requires devel/caf 0.14.X but devel/caf was recently updated to 0.15.3 which is massively incompatible (and currently prevents security/bro 2.4.1 from compiling when the BROKER option is selected). The developers reported that patching bro to work with caf 0.15.X would be difficult so rather than chasing the caf port bro now builds caf 0.14.5 statically. Included are two new patch files from the developers for caf that clean up some sharp edges involved with using caf in this manner.
The new rc.d script was contributed by firstname.lastname@example.org (PR 212433).
Finally, bro is now built using ninja which is what the developers use.
(I have a poudriere build log but apparently it's too buku to attach to this PR.)
Created attachment 180676 [details]
Here is a revised patchset with two improvements. Make CXXFLAGS closer to what the developers use and reduce the number of warning lines by 100X. Also only install rc.d script when BROCTL is selected.
Created attachment 180677 [details]
poudriere build log (with BROKER enabled)
(In reply to leres from comment #2)
Could you revisit the patch with regard to these two portlint findings:
FATAL: Makefile: bro listed in SUB_FILES/USE_RC_SUBR, but files/bro.in is missing.
WARN: /poudriere/ports/default/security/bro/files/patch-aux-broker-CMakeLists.txt: patch was not generated using ``make makepatch''. It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
Created attachment 180753 [details]
New patchset with bro.in included and portlint makepatch warnings fixed.
Note: The patch file names have changed so please remove all old files/patch-* files before applying this patchset.