Bug 217935 - r315408 breaks userboot.so
Summary: r315408 breaks userboot.so
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: CURRENT
Hardware: amd64 Any
: --- Affects Many People
Assignee: Toomas Soome
URL:
Keywords: bhyve, needs-patch, regression
Depends on:
Blocks:
 
Reported: 2017-03-20 04:13 UTC by Fabian Freyer
Modified: 2017-03-20 18:18 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Freyer 2017-03-20 04:13:22 UTC
in r315408, disk_cleanup was removed, which is called at sys/boot/userboot/userboot/userboot_disk.c:113. This causes bhyveload to fail with the following error message:

    /boot/userboot.so: Undefined symbol "disk_cleanup"

Given that disk_cleanup just cleans up some caching, I'm not sure if it's actually needed by userboot. I'll try to whip up a patch to remove that code from sys/boot/userboot/userboot/userboot_disk.c.
Comment 1 Mark Linimon freebsd_committer 2017-03-20 08:13:59 UTC
Over to committer of r315408.
Comment 2 Toomas Soome freebsd_committer 2017-03-20 08:37:48 UTC
(In reply to Fabian Freyer from comment #0)


If you could check https://reviews.freebsd.org/D10060
Comment 3 Fabian Freyer 2017-03-20 15:09:56 UTC
D10060 fixes the problem for me.
Comment 4 commit-hook freebsd_committer 2017-03-20 18:04:14 UTC
A commit references this bug:

Author: tsoome
Date: Mon Mar 20 18:03:40 UTC 2017
New revision: 315645
URL: https://svnweb.freebsd.org/changeset/base/315645

Log:
  loader: disk_cleanup was left in userboot_disk.c

  In r315408, disk_cleanup was removed, which is called at
  sys/boot/userboot/userboot/userboot_disk.c:113.
  This causes bhyveload to fail.

  PR:		217935
  Reported by:	Fabian Freyer
  Reviewed by:	allanjude
  Approved by:	allanjude (mentor)
  Differential Revision:	https://reviews.freebsd.org/D10060

Changes:
  head/sys/boot/userboot/userboot/userboot_disk.c