Bug 217951 - tftp-proxy depends on WITH_PF but not WITH_TFTP
Summary: tftp-proxy depends on WITH_PF but not WITH_TFTP
Status: Closed Not A Bug
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 11.0-STABLE
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-20 13:26 UTC by Philippe Michel
Modified: 2018-08-23 13:15 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Michel 2017-03-20 13:26:12 UTC 
The tftp proxy is installed if pf is available. From libexec/Makefile :

.if ${MK_PF} != "no"
_tftp-proxy=    tftp-proxy
.endif

Shouldn't it depend on tftpd as well, with something like :

.if ${MK_PF} != "no" && ${MK_TFTP} != "no

and the corresponding changes in OptionalObsoleteFiles.inc ?
Comment 1 Alan Somers freebsd_committer freebsd_triage 2018-08-22 16:53:50 UTC 
No, I don't think so.  tftp-proxy forwards connections to a tftp server, which may not be on the same machine as the one running tftp-proxy.  It would be a reasonable configuration to build tftp-proxy but not tftpd.  Or am I missing something?
Comment 2 Philippe Michel 2018-08-23 09:37:04 UTC 
I think you are right. I hadn't properly understood tftp-proxy usage when I opened the PR.