Bug 217998 - sysutils/xfce4-battery-plugin: Update to 1.1.0
Summary: sysutils/xfce4-battery-plugin: Update to 1.1.0
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-xfce (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-22 10:28 UTC by Jochen Neumeister
Modified: 2017-03-24 13:11 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (xfce)

Attachments
Patch (7.15 KB, patch)
2017-03-22 10:28 UTC, Jochen Neumeister 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jochen Neumeister freebsd_committer freebsd_triage 2017-03-22 10:28:31 UTC 
Created attachment 181047 [details]
Patch

Make test and install is fine.

poudriere build fine for:

10.3 amd + i386
11.0 amd + i386
12-current amd + i386 (r314826)

portlint is also fine (ignore warning about generated patch).

Cheers
jochen
Comment 1 Olivier Duchateau 2017-03-24 12:31:26 UTC 
Your patch is not in good shape:

1. It depends of Gtk3, so you must replace USES= xfce by USES= xfce:gtk3 (it requires Gtk3 support into xfce4-panel, it's enabled by default). Moreover sorting USES is better

2. USE_GNOME= intlhack is not necessary

3. Why to remove %%NLS%% keyword in pkg-plist?

4. PORTREVISION is not necessary