Bug 218013 - java/openjfx8-devel gradle dependency check
Summary: java/openjfx8-devel gradle dependency check
Status: Closed Not A Bug
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-22 17:22 UTC by Dr. Jochen Raßler
Modified: 2017-07-22 22:19 UTC (History)
3 users (show)

See Also:


Attachments
gradle.build script update to check for current gradle version 3.2 instead of old 1.8 (890 bytes, patch)
2017-03-28 17:05 UTC, Dr. Jochen Raßler
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dr. Jochen Raßler 2017-03-22 17:22:28 UTC
Although openjfx8-devel works fine using gradle 3.2.1 (as of Bug fix 215677), the build script still explicitly checks for gradle 1.8. I think this can be updated.

Snippet from build-script:

// Check that Gradle 1.8 is in use.
if (gradle.gradleVersion != "1.8") {
    def ver = gradle.gradleVersion.split("[\\.]");
    def gradleMajor = Integer.parseInt(ver[0]);
    def gradleMinor = Integer.parseInt(ver[1]);
    def err = "";
    if (gradleMajor == 1) {
        if (gradleMinor < 8) {
            err = "Gradle version too old: ${gradle.gradleVersion}; must be at least 1.8"
        }

        // Blacklisted versions of gradle
        if (gradleMinor == 11) {
            err = "JavaFX fails to build with Gradle ${gradle.gradleVersion}; supported version is 1.8"
        }
    }

    if (IS_GRADLE_VERSION_CHECK && err != "") {
        fail(err);
    }

    logger.warn("*****************************************************************");
    logger.warn("Unsupported gradle version $gradle.gradleVersion in use.");
    logger.warn("Only version 1.8 is supported. Use this version at your own risk");
    if ( err != "") logger.warn(err);
    logger.warn("*****************************************************************");
}
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2017-03-23 21:46:28 UTC
Note to submitter: this port does not currently have a maintainer.  Would you be interested in taking it over?  Thanks.
Comment 2 Dr. Jochen Raßler 2017-03-24 16:42:10 UTC
(In reply to Mark Linimon from comment #1)

I'm quite new to FreeBSD (less than half a year *BSD experience), but I can give it a try. Where would be a good point to ask if I need support?
Comment 3 Dr. Jochen Raßler 2017-03-28 17:05:29 UTC
Created attachment 181274 [details]
gradle.build script update to check for current gradle version 3.2 instead of old 1.8

this patch should fix the mentioned bug. It only affects the build script and the version check for gradle. No update of openjfx source code has been included yet
Comment 4 Tobias Kortkamp freebsd_committer freebsd_triage 2017-07-22 22:19:10 UTC
I took back maintainership of openjfx8-devel in ports r446432.

Regarding the Gradle warning: It's harmless and I don't think we need
to silence it.  The build should not be affected by it.

If openjfx8-devel stops building because of a Gradle update we can
bring in an older Gradle version for it in the worst case.