Bug 218040 - mail/postsrsd: remove unused dependency
Summary: mail/postsrsd: remove unused dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mathieu Arnold
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-23 12:53 UTC by Mathieu Arnold
Modified: 2017-03-25 19:26 UTC (History)
1 user (show)

See Also:
ports: maintainer-feedback+

Attachments
v1 (667 bytes, patch)
2017-03-23 12:53 UTC, Mathieu Arnold 		no flags Details | Diff
v2 (1.23 KB, patch)
2017-03-23 13:37 UTC, Mathieu Arnold 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Arnold freebsd_committer freebsd_triage 2017-03-23 12:53:56 UTC 
Created attachment 181099 [details]
v1

The build needs base64 only when creating the secrets file, which it is not doing here.

While there, use the new opt_CMAKE_BOOK helper.
Comment 1 Mathieu Arnold freebsd_committer freebsd_triage 2017-03-23 13:37:23 UTC 
Created attachment 181103 [details]
v2

Also, make sure tr runs in a clean environment, if using some non ASCII locale, it will fail at the first character that is not valid in that locale with:

# tr -cd "[:alnum:]" < /dev/urandom | head -c 24
tr: Illegal byte sequence
Comment 2 Krzysztof 2017-03-25 16:47:42 UTC 
Comment on attachment 181103 [details]
v2

Yes, I approve this patch. Thanks a lot for your work.
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-03-25 19:26:08 UTC 
A commit references this bug:

Author: mat
Date: Sat Mar 25 19:25:14 UTC 2017
New revision: 436913
URL: https://svnweb.freebsd.org/changeset/ports/436913

Log:
  Remove unneeded dependency, use the opt_CMAKE_BOOL helper, and make sure
  tr runs without any LC_* set or it will fail.

  PR:		218040
  Submitted by:	mat
  Approved by:	maintainer
  Sponsored by:	Absolight

Changes:
  head/mail/postsrsd/Makefile
  head/mail/postsrsd/files/postsrsd.in