Bug 218048 - graphics/graphviz: Fix build due to no shebang on its iffe script
Summary: graphics/graphviz: Fix build due to no shebang on its iffe script
Status: Closed Unable to Reproduce
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-23 19:43 UTC by Naram Qashat
Modified: 2017-07-07 10:40 UTC (History)
0 users

See Also:
dinoex: maintainer-feedback+


Attachments
graphviz-iffe.patch (3.70 KB, patch)
2017-03-23 19:43 UTC, Naram Qashat
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Naram Qashat 2017-03-23 19:43:19 UTC
Created attachment 181109 [details]
graphviz-iffe.patch

The current version of graphviz appears to try to start a shell script named iffe (from the root of the tarball) within the Makefile of lib/sfio, lib/sfio/Sfio_f and lib/vmalloc. However, said shell script does not contain a shebang, causing sh to throw an error:

/bin/sh: ../../../iffe: not found

The attached patch fixes this by adding a /bin/sh (by way if ${SH} in the port's Makefile) to the invocation of iffe.

* Update Makefile's post-patch
* Add patches for lib/sfio/Makefile.in, lib/sfio/Sfio_f/Makefile.in and lib/vmalloc/Makefile.in
Comment 1 Dirk Meyer freebsd_committer freebsd_triage 2017-05-16 19:11:30 UTC
Unable to reproduce the error the
iffe is executed on FreeBSD 10.3 and FreeBSD 11.0

Which Version  of FreeBSD do you use?
Which Arch
Which Shell?
Comment 2 Naram Qashat 2017-05-16 19:32:44 UTC
I am on FreeBSD 11.0-RELEASE-p8 amd64. My shell is csh, but I've run into this problem within a poudriere jail as well, and I also tested just now with sh and it still fails for me.

I'm really not sure how you haven't run into the problem, since the scripts do not have a shebang on them.
Comment 3 Dirk Meyer freebsd_committer freebsd_triage 2017-05-22 08:37:45 UTC
tested on FreeBSD 11.0-RELEASE-p10

The shell has no problem to execute the files.

Official package is build is without error.

Something in your local setup may differ.

Unless we don't know the reason that causes the error,
I won't apply the suggested patch.
Comment 4 Naram Qashat 2017-05-23 01:09:59 UTC
I honestly have no idea why my current system cannot build without these patches. I tested in a clean VM with csh as the shell and it does indeed build without these patches. I know of nothing going on with my current system's setup that would be causing this to fail.
Comment 5 Dirk Meyer freebsd_committer freebsd_triage 2017-07-07 10:40:40 UTC
If you find further evidence that causes the failure,
please reopen this pr or create a new one.