Bug 218135 - lang/nim: Build additional tools from main source tree, with patch
Summary: lang/nim: Build additional tools from main source tree, with patch
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-03-26 06:00 UTC by Felix Hanley
Modified: 2018-02-09 08:53 UTC (History)
2 users (show)

See Also:
ports: maintainer-feedback-


Attachments
Diff to add option to build and install Nim tools (1.40 KB, patch)
2017-03-26 06:00 UTC, Felix Hanley
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Hanley 2017-03-26 06:00:05 UTC
Created attachment 181205 [details]
Diff to add option to build and install Nim tools

Since Nim 0.15.0 nimble, nimgrep and nimsuggest are now bundled with Nim (according to https://github.com/nim-lang/nimble & https://github.com/nim-lang/nimsuggest). This patch adds an option to build and install them along with Nim.

The devel/nimble package could probably also be removed if these changes are applied.
Comment 1 Neal Nelson 2017-03-27 08:55:25 UTC
The reason that Nimble is a separate port is because the build process included in the Nim distribution fetches the source from git independently. I'm not sure that it's allowed to bypass the port distribution fetching process like this. Also it would require an added build dependency on git which your patch does not include.

The source for nimgrep and nimsuggest are included in the Nim distribution, so it would be possible to build them with the lang/nim port, but it would be necessary to patch koch.nim in order to not build nimble. This is just the removal of the call to buildNimble at the end of buildTools I think.
Comment 2 Neal Nelson 2017-05-18 15:00:13 UTC
Bug #219381 updates nim to 0.17.0 and includes these suggested changes, except for Nimble of course which still has a separate port.
Comment 3 Walter Schwarzenfeld 2018-02-08 18:47:20 UTC
Is this solved, could it be closed?
Comment 4 Neal Nelson 2018-02-09 06:44:24 UTC
As said in comment 2, this has already been addressed and therefore can be closed.