Bug 218268 - [PATCH] print/magicfilter: RUN_DEPENDS unintended side effects
Summary: [PATCH] print/magicfilter: RUN_DEPENDS unintended side effects
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-03-31 16:44 UTC by Andreas Hollmann
Modified: 2018-08-22 07:25 UTC (History)
1 user (show)

See Also:


Attachments
Simple fix (583 bytes, patch)
2017-03-31 16:44 UTC, Andreas Hollmann
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Hollmann 2017-03-31 16:44:55 UTC
Created attachment 181359 [details]
Simple fix

Defining 'RUN_DEPENDS+=  ${BUILD_DEPENDS}' results in uninteded side effects in case of using ccache by defining WITH_CCACHE_BUILD=yes in your /etc/make.conf. 

ccache is added to BUILD_DEPENDS and ends up in RUN_DEPENDS.
Comment 1 Bryan Drewery freebsd_committer freebsd_triage 2017-04-10 17:08:58 UTC
This is known and not just limited to WITH_CCACHE_BUILD. You need to use RUN_DEPENDS:= ${BUILD_DEPENDS}
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-08-21 16:18:16 UTC
A commit references this bug:

Author: tobik
Date: Tue Aug 21 16:17:37 UTC 2018
New revision: 477722
URL: https://svnweb.freebsd.org/changeset/ports/477722

Log:
  print/magicfilter: Prevent ccache from being accidentally added as a run dependency

  PR:		218268
  Submitted by:	Andreas Hollmann <andreas.hollmann@gmail.com>

Changes:
  head/print/magicfilter/Makefile
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-08-22 07:25:32 UTC
A commit references this bug:

Author: tobik
Date: Wed Aug 22 07:25:22 UTC 2018
New revision: 477773
URL: https://svnweb.freebsd.org/changeset/ports/477773

Log:
  print/magicfilter: Canonicalize RUN_DEPENDS

  PR:		218268
  Reported by:	mat

Changes:
  head/print/magicfilter/Makefile