Created attachment 181361 [details]
port diff

1. Some people have firewalls that are not or cannot be configured to allow ftp out. qjail used native ftp to download the base file issued by the "qjail install" logic. Changed it to use the "fetch http" command instead of the native ftp command. 

2. Installed the hs-shellcheck package. Used it to check the qjail script. Even though the qjail script has been in production mode for 7+ years, thought it would be good to verify the code was up to good standards. It found some things that were not up to standard that I fixed. The changes in no way effected the existing logic flow.

3. Ran the updated qjail script through a testing cycle looking for any problems that may have been caused by the shellcheck changes I made. None were found.

4. The testing cycle did bring to light three problems that unknowingly existed before the shellcheck changes were made.

   A. The verify_ip routine was not working correctly. Fixed it.
   B. The bpf devfs rule 50 was not working correctly. Fixed it.
   C. Added check to -d option [# of jails to duplicate] of the 
      create function. No IPv6 addresses are allowed, only a single
      IPv4 address is allowed.

5. Ran shellcheck on "qjail.bootime" script and fixed same kind of things as in the qjail script.