Bug 218288 - [UPDATE] multimedia/handbrake to 1.0.3
Summary: [UPDATE] multimedia/handbrake to 1.0.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2017-04-01 10:35 UTC by Yuichiro NAITO
Modified: 2017-04-04 17:50 UTC (History)
1 user (show)

See Also:


Attachments
update multimedia/handbrake to 1.0.3 (21.78 KB, text/plain)
2017-04-01 10:35 UTC, Yuichiro NAITO
no flags Details
Updated tarball of new handbrake port (6.60 KB, application/x-bzip)
2017-04-02 18:14 UTC, Thomas Zander
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yuichiro NAITO 2017-04-01 10:35:01 UTC
Created attachment 181382 [details]
update multimedia/handbrake to 1.0.3

Attached shar file is a updated port of HandBrake to 1.0.3.
Will you see the shar file and replace multimedia/handbrake ?

While I'm making patch files,
I updated almost all files.
So I decided to archive whole files into shar.

Portlint warns only one message.

"WARN: Makefile: Consider adding support for a NLS knob to conditionally disable gettext support."

I have no idea about this.

I tested on my FreeBSD-11.0R amd64 and it works.
I could compile on FreeBSD-11.0R i386 but I didn't test on i386.
Comment 1 Thomas Zander freebsd_committer 2017-04-02 18:14:23 UTC
Created attachment 181405 [details]
Updated tarball of new handbrake port

Based on your port, I did some modification that imho make sense:
- Fix FDK_AAC stuff
- Fix plist (OPTIONS_SUB, X11) generation
- Make x265 mandatory
- ln -sf ghb to HandBrake (POLA)

Since I am not an avid HandBrake user, could you test this and check whether everything works as expected?
Comment 2 Yuichiro NAITO 2017-04-04 00:49:42 UTC
(In reply to Thomas Zander from comment #1)

Thanks for reviewing.
I checked compiling your fix and tested on my movie files.
Everything works fine.
There is no problem for me.
Comment 3 commit-hook freebsd_committer 2017-04-04 17:48:37 UTC
A commit references this bug:

Author: riggs
Date: Tue Apr  4 17:48:27 UTC 2017
New revision: 437745
URL: https://svnweb.freebsd.org/changeset/ports/437745

Log:
  Update to upstream version 1.0.3

  PR:		218288
  Submitted by:	naito.yuichiro@gmail.com
  Reviewed by:	riggs

Changes:
  head/multimedia/handbrake/Makefile
  head/multimedia/handbrake/distinfo
  head/multimedia/handbrake/files/patch-build_contrib_x264_x264_configure
  head/multimedia/handbrake/files/patch-contrib-ffmpeg-A04-x86-asm-h.patch
  head/multimedia/handbrake/files/patch-contrib-mp4v2-P01-freebsd-clang-namespace.patch
  head/multimedia/handbrake/files/patch-contrib_ffmpeg_A90-libvpx-1.5.0.patch
  head/multimedia/handbrake/files/patch-contrib_ffmpeg_module.defs
  head/multimedia/handbrake/files/patch-contrib_libbluray_A02-expose-clip__id.patch
  head/multimedia/handbrake/files/patch-custom.defs
  head/multimedia/handbrake/files/patch-gtk_configure.ac
  head/multimedia/handbrake/files/patch-gtk_src_callbacks.c
  head/multimedia/handbrake/files/patch-libhb_fifo.c
  head/multimedia/handbrake/files/patch-libhb_module.defs
  head/multimedia/handbrake/files/patch-libhb_nlmeans.c
  head/multimedia/handbrake/files/patch-libhb_nlmeans__x86.c
  head/multimedia/handbrake/files/patch-make_configure.py
  head/multimedia/handbrake/files/patch-make_include_contrib.defs
  head/multimedia/handbrake/files/patch-make_include_gcc.defs
  head/multimedia/handbrake/files/patch-make_include_main.defs
  head/multimedia/handbrake/files/patch-make_include_select.defs
  head/multimedia/handbrake/files/patch-scripts_build-presets.sh
  head/multimedia/handbrake/files/patch-scripts_create__resources.py
  head/multimedia/handbrake/files/patch-scripts_mac-toolchain-build
  head/multimedia/handbrake/files/patch-scripts_manicure.rb
  head/multimedia/handbrake/files/patch-scripts_mingw-w64-build
  head/multimedia/handbrake/files/patch-scripts_quotestring.py
  head/multimedia/handbrake/files/patch-scripts_repo-info.sh
  head/multimedia/handbrake/files/patch-scripts_tag-release.sh
  head/multimedia/handbrake/files/patch-test_module.defs
  head/multimedia/handbrake/files/patch-version.txt
  head/multimedia/handbrake/pkg-descr
  head/multimedia/handbrake/pkg-plist
Comment 4 Thomas Zander freebsd_committer 2017-04-04 17:50:35 UTC
Thank you very much for the heavy lifting of updating this port and testing. It sure is not an easy one!