Bug 218399 - print/gl2ps: LLD linker update to Makefile.lib
Summary: print/gl2ps: LLD linker update to Makefile.lib
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Marcelo Araujo
URL:
Keywords:
Depends on:
Blocks: 214864
  Show dependency tree / graph
 
Reported: 2017-04-05 13:54 UTC by Ed Maste
Modified: 2017-08-24 13:28 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (araujo)

Attachments
patch to add /usr/lib to link commandline (428 bytes, patch)
2017-04-05 13:54 UTC, Ed Maste 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Maste freebsd_committer freebsd_triage 2017-04-05 13:54:30 UTC 
Created attachment 181507 [details]
patch to add /usr/lib to link commandline

Makefile.lib sets LDFLAGS like so:

LDFLAGS=       -shared -E -lGL -L${LOCALBASE}/lib -lX11 -lXi -lXmu -lm -lz

The LLD linker does not include default search paths, so /usr/lib has to be explicitly specified, in addition to /usr/local/lib, as in the attached patch.

This will unblock 101 skipped ports in the LLD exp-run (PR 214864).
Comment 1 Ed Maste freebsd_committer freebsd_triage 2017-08-18 13:35:49 UTC 
Ping.
Comment 2 Marcelo Araujo freebsd_committer freebsd_triage 2017-08-23 15:53:55 UTC 
(In reply to Ed Maste from comment #1)

Hi, pong!

I'm alive... I will check this one tomorrow (Taiwan Time).


Sorry about my delay!
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-08-24 09:01:58 UTC 
A commit references this bug:

Author: araujo
Date: Thu Aug 24 09:01:11 UTC 2017
New revision: 448652
URL: https://svnweb.freebsd.org/changeset/ports/448652

Log:
  The LLD linker does not include default search paths,
  so /usr/lib has to be explicitly specified also bump PORTREVISION.

  PR:		ports/218399
  Submitted by:	emaste

Changes:
  head/print/gl2ps/Makefile
  head/print/gl2ps/files/Makefile.lib
Comment 4 Marcelo Araujo freebsd_committer freebsd_triage 2017-08-24 09:13:44 UTC 
Done! Thanks.

Sorry the delay!
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-08-24 09:14:09 UTC 
A commit references this bug:

Author: araujo
Date: Thu Aug 24 09:13:09 UTC 2017
New revision: 448656
URL: https://svnweb.freebsd.org/changeset/ports/448656

Log:
  Bump PORTREVISION to reflect print/gl2ps changes.

  PR:		ports/218399 (based on)
  Submitted by:	emaste

Changes:
  head/cad/opencascade/Makefile
  head/math/octave/Makefile
  head/math/vtk5/Makefile
  head/science/paraview/Makefile
Comment 6 Nikolai Lifanov freebsd_committer freebsd_triage 2017-08-24 13:23:54 UTC 
Does it make sense to add -L/usr/lib globally in case !LLD_UNSAFE?
Comment 7 Ed Maste freebsd_committer freebsd_triage 2017-08-24 13:28:19 UTC 
There's no trouble adding it always.