While building audio/logitechmediaserver on 11-stable I encountered a C++ compile error in the ICU related code. Once I made the following change, I was able to compile and run the package successfully.
The compiler error (I am guessing that llvm 4.0.0 is detecting it for the first time) is for a unique line that looks like this:
if (position > 0)
position is a pointer ... based on context, I believe what they intended was
if (*position > 0)
when I made this change, I was able to build the package and run it.
We could patch this, but it might be better to submit a patch upstream.
Makes sense, will do. Thank you!
(In reply to Ken Wellsch from comment #0)
> uspoof.cpp:369:22: error: ordered comparison between pointer and zero ('int32_t *' (aka 'int *') and 'int')
GCC can also detect these via -Werror=extra. Clang 4.0 made them fatal for C++ but C users are left even without a warning.
(In reply to Mark Dixon from comment #1)
> We could patch this, but it might be better to submit a patch upstream.
Created a branch to update logitechmediaserver here:
That contains a hack / patch to make this compile.
This should really be fixed upstream in slimserver-vendor (not libicu where it was fixed 5 years ago)
Fixes (bug, build, run) should be provided separately from version updates so that they can be merged to the quarterly branch
This was fixed by PR 220781
Assign to committer that resolved
Update resolution to FIXED, was resolved with a commit