Bug 218585 - www/firefox: fails to patch with SNDIO=on
Summary: www/firefox: fails to patch with SNDIO=on
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-gecko (Nobody)
URL:
Keywords: patch, regression
Depends on:
Blocks:
 
Reported: 2017-04-12 10:21 UTC by Marco Beishuizen
Modified: 2017-04-12 17:22 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (gecko)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marco Beishuizen 2017-04-12 10:21:21 UTC 
Applying patch on FF 53.0 fails with:
===> Fetching all distfiles required by firefox-53.0,1 for building
===>  Extracting for firefox-53.0,1
=> SHA256 Checksum OK for firefox-53.0.source.tar.xz.
===>  Patching for firefox-53.0,1
===>  Applying FreeBSD patches for firefox-53.0,1
No such line 323 in input file, ignoring
sed: /usr/ports/www/firefox/work/firefox-53.0/media/libcubeb/tests/moz.build: No such file or directory
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/www/firefox
*** Error code 1

Stop.
make: stopped in /usr/ports/www/firefox
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2017-04-12 12:13:37 UTC 
This is a problem when SNDIO=on.  Please try with this patch https://pkg.tobik.me/patches/bsd.gecko.mk.diff
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-04-12 17:21:36 UTC 
A commit references this bug:

Author: jbeich
Date: Wed Apr 12 17:20:39 UTC 2017
New revision: 438394
URL: https://svnweb.freebsd.org/changeset/ports/438394

Log:
  www/firefox: unbreak SNDIO=on

  ===>  Applying FreeBSD patches for firefox-53.0,1
  No such line 323 in input file, ignoring
  sed: /usr/ports/www/firefox/work/firefox-53.0/media/libcubeb/tests/moz.build: No such fileor directory
  *** Error code 1

  PR:		218585
  Reported by:	jrm, Marco Beishuizen
  Submitted by:	tobik
  MFH:		2017Q2 (r438264 followup)

Changes:
  head/Mk/bsd.gecko.mk