Bug 218616 - dns/opendnssec13: Pull in textproc/gnugrep for a proper grep(1) with GNU extensions
Summary: dns/opendnssec13: Pull in textproc/gnugrep for a proper grep(1) with GNU exte...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Larry Rosenman
URL:
Keywords:
Depends on:
Blocks: 218385
  Show dependency treegraph
 
Reported: 2017-04-13 00:29 UTC by Kyle Evans
Modified: 2017-04-26 01:31 UTC (History)
4 users (show)

See Also:
jaap: maintainer-feedback+


Attachments
svn(1) diff of dns/opendnssec13 (697 bytes, patch)
2017-04-13 00:29 UTC, Kyle Evans
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Evans freebsd_committer freebsd_triage 2017-04-13 00:29:54 UTC
Created attachment 181745 [details]
svn(1) diff of dns/opendnssec13

Hi,

The AUDITOR option does a check for a proper grep(1) complete with GNU extensions. For the time being, use the more up to date version of GNU grep, textproc/gnugrep, rather than relying on GNU extensions in base grep. This was identified in a recent exp-run to test installing BSD grep as /usr/bin/grep and disable GNU grep compatibility in the process.
Comment 1 Jaap Akkerhuis 2017-04-14 12:14:20 UTC
(In reply to Kyle Evans from comment #0)
Note that the port is deprecated and is reaching EOL pretty soon. The newer versions of  opendnssec don't have the auditor anymore. So one really should update.

Other then that, no objections to the patch.
Comment 2 Kyle Evans freebsd_committer freebsd_triage 2017-04-18 21:02:57 UTC
(In reply to jaap from comment #1)

Hello!

Thank you for your response and feedback. =) It probably is a good idea for this to get applied anyways, given how quarterlies work out and whatnot -- I'd rather not get you notified of breakage on a port that's supposed to be going away when the change does come.
Comment 3 Jaap Akkerhuis 2017-04-18 21:38:37 UTC
(In reply to Kyle Evans from comment #2)
Go ahead, apply the patch, no problem.

It is likely good for the still active that as a side effect of this of this patch they get a notification this is EOL.
Comment 4 Larry Rosenman freebsd_committer freebsd_triage 2017-04-26 01:06:14 UTC
take
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-04-26 01:30:37 UTC
A commit references this bug:

Author: ler
Date: Wed Apr 26 01:30:01 UTC 2017
New revision: 439426
URL: https://svnweb.freebsd.org/changeset/ports/439426

Log:
  dns/opendnssec13: Pull in textproc/gnugrep for a proper grep(1) with GNU extensions

  PR:	218616
  Submitted by:	Kyle Evans <bsdports@kyle-evans.net>
  Approved by:	<jaap@NLnetLabs.nl> (maintainer), adamw (mentor)
  Differential Revision:	https://reviews.freebsd.org/D10503

Changes:
  head/dns/opendnssec13/Makefile
Comment 6 Larry Rosenman freebsd_committer freebsd_triage 2017-04-26 01:31:31 UTC
Commmitted, Thanks!