Bug 218643 - www/node: Update to v7.9.0
Summary: www/node: Update to v7.9.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Thomas Zander
URL: https://nodejs.org/en/blog/release/v7...
Keywords:
Depends on: 218081
Blocks:
  Show dependency treegraph
 
Reported: 2017-04-13 19:23 UTC by Bradley T. Hughes
Modified: 2017-04-14 19:12 UTC (History)
1 user (show)

See Also:


Attachments
www/node: Update to v7.9.0 (1.51 KB, patch)
2017-04-13 19:23 UTC, Bradley T. Hughes
bhughes: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bradley T. Hughes freebsd_committer 2017-04-13 19:23:27 UTC
Created attachment 181767 [details]
www/node: Update to v7.9.0

Update to the latest upstream release.

portlint: OK (-C, spurious warnings about /etc/make.conf and python use)
testport: OK (poudriere, 11.0-R, 10.3-R, amd64/i386, default options)
testport: OK (poudriere, 11.0-R, 10.3-R, amd64/i386, BUNDLED_SSL)

When building with the armv6 patch from PR 218081:

testport: OK (poudriere, 11.0-R, armv6, default options)
testport: OK (poudriere, 11.0-R, armv6, BUNDLED_SSL)
Comment 1 commit-hook freebsd_committer 2017-04-14 12:20:04 UTC
A commit references this bug:

Author: riggs
Date: Fri Apr 14 12:19:31 UTC 2017
New revision: 438506
URL: https://svnweb.freebsd.org/changeset/ports/438506

Log:
  Update to upstream version 7.9.0, fix build on armv6

  PR:		218081, 218643
  Submitted by:	mikael.urankar@gmail.com,
  		bradleythughes@fastmail.fm (maintainer)
  Approved by:	bradleythughes@fastmail.fm (maintainer)

Changes:
  head/www/node/Makefile
  head/www/node/distinfo
  head/www/node/files/patch-deps_v8_src_base_atomicops__internals__arm__gcc.h
  head/www/node/files/patch-node.gyp
  head/www/node/pkg-plist
Comment 2 Thomas Zander freebsd_committer 2017-04-14 12:27:09 UTC
Patchfile was incomplete, pkg-plist was missing the following entries:

===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/lldb_commands.py
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/lldbinit
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1

I took the liberty of fixing those when committing.

Also, probably not ultra-urgent, but maybe worth a look: I don't get this to compile with gcc 5.x. The following happens during build with gcc 5:

  g++5 '-DV8_TARGET_ARCH_IA32' '-DENABLE_DISASSEMBLER' '-DV8_I18N_SUPPORT' -I/wrkdirs/usr/ports/www/node/work/node-v7.9.0/out/Release/obj/gen -I/wrkdirs/usr/ports/www/node/work/node-v7.9.0/out/Release/obj/gen/include -I../deps/v8_inspector/include -I../deps/v8_inspector -I../deps/v8 -I../deps/v8/include  -pthread -Wall -Wextra -Wno-unused-parameter -m32 -msse2 -mfpmath=sse -mmmx -fno-strict-aliasing -m32 -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++0x -MMD -MF /wrkdirs/usr/ports/www/node/work/node-v7.9.0/out/Release/.deps//wrkdirs/usr/ports/www/node/work/node-v7.9.0/out/Release/obj.target/standalone_inspector/deps/v8_inspector/src/inspector/v8-value-copier.o.d.raw -isystem /usr/local/include -O2 -pipe -fstack-protector -Wl,-rpath=/usr/local/lib/gcc5 -isystem /usr/local/include -fno-strict-aliasing  -Wl,-rpath=/usr/local/lib/gcc5 -isystem /usr/local/include -c -o /wrkdirs/usr/ports/www/node/work/node-v7.9.0/out/Release/obj.target/standalone_inspector/deps/v8_inspector/src/inspector/v8-value-copier.o ../deps/v8_inspector/src/inspector/v8-value-copier.cc
  LD_LIBRARY_PATH=/wrkdirs/usr/ports/www/node/work/node-v7.9.0/out/Release/lib.host:/wrkdirs/usr/ports/www/node/work/node-v7.9.0/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../deps/v8/src; mkdir -p /wrkdirs/usr/ports/www/node/work/node-v7.9.0/out/Release/obj.target/v8_base/geni; "/wrkdirs/usr/ports/www/node/work/node-v7.9.0/out/Release/mkpeephole" "/wrkdirs/usr/ports/www/node/work/node-v7.9.0/out/Release/obj.target/v8_base/geni/bytecode-peephole-table.cc"
gmake[2]: *** [deps/v8/src/v8_base.target.mk:13: /wrkdirs/usr/ports/www/node/work/node-v7.9.0/out/Release/obj.target/v8_base/geni/bytecode-peephole-table.cc] Segmentation fault
gmake[2]: *** Waiting for unfinished jobs....
Comment 3 Bradley T. Hughes freebsd_committer 2017-04-14 18:42:55 UTC
Thanks! :)
Comment 4 Bradley T. Hughes freebsd_committer 2017-04-14 19:12:54 UTC
I will see if I get some time to look at the gcc 5 build problem. Looks like it's the compiler that segfaults...