Bug 218691 - bsd.port.mk: Use POSIX conformant expressions with grep(1)
Summary: bsd.port.mk: Use POSIX conformant expressions with grep(1)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks: 218385
  Show dependency tree / graph
 
Reported: 2017-04-16 17:00 UTC by Kyle Evans
Modified: 2017-04-21 19:37 UTC (History)
2 users (show)

See Also:

Attachments
svn(1) diff of bsd.port.mk (710 bytes, patch)
2017-04-16 17:00 UTC, Kyle Evans 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Evans freebsd_committer freebsd_triage 2017-04-16 17:00:15 UTC 
Created attachment 181827 [details]
svn(1) diff of bsd.port.mk

Hi,

Not directly found by the exp-run in PR 21835, but an audit stemming from that found one case of a expression not IEEE 1003.2 conformant (branching in a BRE) being used with grep(1) in bsd.port.mk.

This can be fixed by switching to use egrep for branching, patch is attached.
Comment 1 Mathieu Arnold freebsd_committer freebsd_triage 2017-04-20 10:46:36 UTC 
Did this patch go through an exp-run ?
Comment 2 Kyle Evans freebsd_committer freebsd_triage 2017-04-20 12:14:22 UTC 
(In reply to Mathieu Arnold from comment #1)

Negative, since it's a pretty automatic and straightforward change from a BRE to an ERE. One could be requested for it if it's necessary, though, I suppose.
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-04-21 19:37:34 UTC 
A commit references this bug:

Author: antoine
Date: Fri Apr 21 19:36:36 UTC 2017
New revision: 439126
URL: https://svnweb.freebsd.org/changeset/ports/439126

Log:
  Use POSIX conformant expressions with grep(1)

  PR:		218691
  Submitted by:	Kyle Evans
  With hat:	portmgr

Changes:
  head/Mk/bsd.port.mk