Bug 218705 - [NEW PORT]: games/tribaltrouble: real time strategy game
Summary: [NEW PORT]: games/tribaltrouble: real time strategy game
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-17 15:15 UTC by Christian Sturm
Modified: 2018-06-18 22:46 UTC (History)
2 users (show)

See Also:

Attachments
Shell archive containing the new port (2.54 KB, text/plain)
2017-04-17 15:15 UTC, Christian Sturm 		no flags Details
games/tribaltrouble port (2.54 KB, text/plain)
2017-04-17 16:57 UTC, Christian Sturm 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Sturm 2017-04-17 15:15:58 UTC 
Created attachment 181844 [details]
Shell archive containing the new port

I got Tribal Trouble to work and created a port. It's a real time strategy game that was open sourced.

Portlint says:

FATAL: Makefile: you should use ${JAVALIBDIR} in BUILD_DEPENDS/RUN_DEPENDS to define dependencies on JAR files installed in ${JAVAJARDIR}

However, ${JAVALIBDIR} is actually used.
Comment 1 Christian Sturm 2017-04-17 16:55:56 UTC 
Comment on attachment 181844 [details]
Shell archive containing the new port

obsoleted by newer version
Comment 2 Christian Sturm 2017-04-17 16:57:16 UTC 
Created attachment 181849 [details]
games/tribaltrouble port

This is the newer version. It contains a fix that makes the game run in registered mode, rather than the demo version.
Comment 3 Walter Schwarzenfeld freebsd_triage 2018-01-10 03:49:41 UTC 
ping!
Comment 4 Tobias Kortkamp freebsd_committer freebsd_triage 2018-06-06 18:40:42 UTC 
Sorry that you haven't gotten any feedback for over a year!
Here are some things that would need to be fixed to get this into the ports
tree:

- It needs a better pkg-descr (see [1] on how to write a better one).

- This doesn't seem to be from the original upstream.  Did you have
  to apply many patches?  If not maybe base it on the real upstream
  and add patches to the port.  Or maybe it's possible to get upstream
  to merge them?

- Add LICENSE_FILE

- Why does the build need Mercurial?

- The Makefile is badly ordered. See [2].

- Please provide some confirmation that this passes portlint and
  Poudriere testport.

[1] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-desc.html
[2] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-order.html