Bug 218723 - mail/drac: fix @sample
Summary: mail/drac: fix @sample
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2017-04-18 08:23 UTC by takefu
Modified: 2018-12-25 07:23 UTC (History)
1 user (show)

See Also:

Attachments
drac-1.12_9.patch (5.45 KB, patch)
2017-04-18 08:23 UTC, takefu 		no flags Details | Diff
drac-1.12_9_2.patch (6.54 KB, patch)
2017-09-06 08:22 UTC, takefu 		no flags Details | Diff
drac-1.12_9_3.patch (6.49 KB, patch)
2017-09-08 06:02 UTC, takefu 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description takefu 2017-04-18 08:23:47 UTC 
Created attachment 181861 [details]
drac-1.12_9.patch

Compliant with portlint
@Sample aggregated
Comment 1 Mathieu Arnold freebsd_committer freebsd_triage 2017-04-18 15:24:16 UTC 
The opt_VARS usage seems dubious.
Comment 2 takefu 2017-09-06 08:22:50 UTC 
Created attachment 186111 [details]
drac-1.12_9_2.patch

The opt_VARS problem solved.
Comment 3 Mathieu Arnold freebsd_committer freebsd_triage 2017-09-06 09:44:53 UTC 
The opt_VARS usage is still wrong.
Comment 4 takefu 2017-09-08 06:02:17 UTC 
Created attachment 186162 [details]
drac-1.12_9_3.patch

How about this?
Comment 5 Walter Schwarzenfeld freebsd_triage 2018-01-16 15:37:54 UTC 
Feedback please!
Comment 6 Tobias Kortkamp freebsd_committer freebsd_triage 2018-11-18 13:01:14 UTC 
(In reply to w.schwarzenfeld from comment #5)

Patch no longer applies cleanly and does way more than what's in
the summary.

LICENSE_PERMS are now more restrictive than before.  Is redistributing
the sources and a binary package of it no longer allowed?  The license
seems like a BSD4CLAUSE variant to me, so probably it's fine.
Comment 7 Walter Schwarzenfeld freebsd_triage 2018-11-18 14:38:42 UTC 
It is the question if it is not a deprecated port. Last version update is from 26 Mar 2003. Source only
fetchable from distcache
Comment 8 Tobias Kortkamp freebsd_committer freebsd_triage 2018-11-18 14:49:03 UTC 
(In reply to w.schwarzenfeld from comment #7)
Even more reason to get LICENSE_PERMS right.  If it's supposed to be preserved
we need to host the distfile somewhere else too.  Without 'dist-mirror' it
wouldn't even be in the distcache.

I'm also ok with deprecating old unmaintained stuff though ;-)
Comment 9 commit-hook freebsd_committer freebsd_triage 2018-12-25 07:23:30 UTC 
A commit references this bug:

Author: tobik
Date: Tue Dec 25 07:22:49 UTC 2018
New revision: 488296
URL: https://svnweb.freebsd.org/changeset/ports/488296

Log:
  Deprecate mail/drac

  Upstream appears to be gone and the last release was in 2003.

  PR:		218723
  Submitted by:	w.schwarzenfeld@utanet.at

Changes:
  head/mail/drac/Makefile
Comment 10 Tobias Kortkamp freebsd_committer freebsd_triage 2018-12-25 07:23:42 UTC 
(In reply to w.schwarzenfeld from comment #7)
Given lack of additional feedback I have deprecated it now.